Task #84375

Epic #84272: Use PSR-7 ServerRequestInterface in backend controllers

Use ServerRequestInterface in PageLayoutController

Added by Łukasz Uznański over 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-03-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

Use ServerRequestInterface in PageLayoutController


Related issues

Related to TYPO3 Core - Bug #86277: Editlock blocks edit button also for admin Closed 2018-09-16
Related to TYPO3 Core - Bug #88092: PageLayoutView::getLocalizedPageTitle() has wrong null coalesce usage in condition Closed 2019-04-05

Associated revisions

Revision d5f61990 (diff)
Added by Aljoscha Weber about 1 year ago

[TASK] Use ServerRequestInterface in PageLayoutController

Replace _GP, getIndpEnv usages with request related functions.

Also deprecate public access to all method except the entry point.

Resolves: #84375
Releases: master
Change-Id: I8050afe519dcbabfd6381c55844c81713482687e
Reviewed-on: https://review.typo3.org/57329
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 5600691c (diff)
Added by Andreas Fernandez 6 months ago

[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Mona Muzaffar <>
Reviewed-by: André Schließer <>
Reviewed-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Tested-by: Mona Muzaffar <>
Tested-by: André Schließer <>
Tested-by: Anja Leichsenring <>

Revision 7bbbb2fc (diff)
Added by Andreas Fernandez 6 months ago

[BUGFIX] Fix null coalesce evaluation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60406
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Mathias Brodala over 1 year ago

  • Tracker changed from Bug to Task

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#6 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#7 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#8 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#9 Updated by Gerrit Code Review about 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#13 Updated by Gerrit Code Review about 1 year ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#14 Updated by Gerrit Code Review about 1 year ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#15 Updated by Gerrit Code Review about 1 year ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#16 Updated by Gerrit Code Review about 1 year ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#17 Updated by Gerrit Code Review about 1 year ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#18 Updated by Gerrit Code Review about 1 year ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#19 Updated by Gerrit Code Review about 1 year ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#20 Updated by Gerrit Code Review about 1 year ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#21 Updated by Gerrit Code Review about 1 year ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#22 Updated by Gerrit Code Review about 1 year ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#23 Updated by Gerrit Code Review about 1 year ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57329

#24 Updated by Aljoscha Weber about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#25 Updated by Mathias Brodala about 1 year ago

  • Related to Bug #86277: Editlock blocks edit button also for admin added

#26 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

#27 Updated by Andreas Fernandez 6 months ago

  • Related to Bug #88092: PageLayoutView::getLocalizedPageTitle() has wrong null coalesce usage in condition added

Also available in: Atom PDF