Task #88133
closed
Required code change in PageRouter
100%
Description
In TYPO3\CMS\Core\Routing\PageRouter:
public function matchRequest(ServerRequestInterface $request, RouteResultInterface $previousResult = null): RouteResultInterface
{
$urlPath = $previousResult->getTail();
According to Benni != null should be removed.
Updated by Benni Mack over 5 years ago
Thanks for opening this ticket.
However, I found out that the RouterInterface uses the same logic, so we'd need the interface to change as well.
The original idea was to use the same Interface for SiteMatcher as well, however, I never went through with this.
So we have two options:
a) Make the change and also the interface, making it kind of breaking.
b) catch the null issue in PageRouter to make an early return, make the Interface Change in v10 only
What do you think?
Updated by Dmitry Dulepov over 5 years ago
Option "b" would be sufficient solution and also no brainer.
However I do not think that interface should change because I think I saw a place where another router is called without a second argument. I can be mistaken about this but I think there was something like this in the code.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60474
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60489
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60489
Updated by Benni Mack over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0480e3849bcbef7e463dd8115cfab4b6357f14f4.