Project

General

Profile

Actions

Feature #88162

closed

Persistent search in CodeMirror for t3Editor

Added by Sven Juergens over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-04-17
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Hi,

I use the search within TypoScript templates in the backend very much, but in the context of CodeMirror in TYPO3 9.x the normal browser search works not anymore. Therefore I have to use the CodeMirror search (Ctrl-F / Cmd-F). It would be nice if the search dialog did not disappear again and again. CodeMirror itself has an option that requires only a keyboard shortcut. Here's an example from https://codemirror.net/demo/search.html with key: "Alt + F"
In order to use this, only the initialisation in typo3/sysext/t3editor/Resources/Public/JavaScript/T3editor.js needs to be adjusted in this way:

in the part "extraKeys"

 extraKeys: {
                "Ctrl-Alt-F": ...
                ...
}

add

 extraKeys: {
                "Alt-F": "findPersistent",
                "Ctrl-Alt-F": ...
                ...
}

would be great to have that in core :)


Files

cmd-f--and--ctrl-f--on-mac.mp4 (700 KB) cmd-f--and--ctrl-f--on-mac.mp4 Preview of Ctrl+f and Cmd+f on a mac Sven Juergens, 2019-04-17 13:37
88162_codemirror-overlaybug.gif (114 KB) 88162_codemirror-overlaybug.gif Josef Glatz, 2019-04-18 15:49
Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60490

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60490

Actions #4

Updated by Josef Glatz over 5 years ago

My notes on patch set 2

Nice improvement. However, as the search get's somehow grayed out when you press enter for search, the UI is broken if the first search result is found on the first line of the code editor. But have a look at the following gif – 1000x better than my english ;-)

Actions #5

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60519

Actions #6

Updated by Andreas Fernandez over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60519

Actions #8

Updated by Andreas Fernandez over 5 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF