Feature #88162
closedPersistent search in CodeMirror for t3Editor
100%
Description
Hi,
I use the search within TypoScript templates in the backend very much, but in the context of CodeMirror in TYPO3 9.x the normal browser search works not anymore. Therefore I have to use the CodeMirror search (Ctrl-F / Cmd-F). It would be nice if the search dialog did not disappear again and again. CodeMirror itself has an option that requires only a keyboard shortcut. Here's an example from https://codemirror.net/demo/search.html with key: "Alt + F"
In order to use this, only the initialisation in typo3/sysext/t3editor/Resources/Public/JavaScript/T3editor.js needs to be adjusted in this way:
in the part "extraKeys"
extraKeys: {
"Ctrl-Alt-F": ...
...
}
add
extraKeys: {
"Alt-F": "findPersistent",
"Ctrl-Alt-F": ...
...
}
would be great to have that in core :)
Files
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60490
Updated by Sven Juergens over 5 years ago
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60490
Updated by Josef Glatz over 5 years ago
My notes on patch set 2¶
Nice improvement. However, as the search get's somehow grayed out when you press enter for search, the UI is broken if the first search result is found on the first line of the code editor. But have a look at the following gif – 1000x better than my english ;-)
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60519
Updated by Andreas Fernandez over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 67bce955dee6899a0a64afe7a2e55ed835617e34.
Updated by Gerrit Code Review over 5 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60519
Updated by Andreas Fernandez over 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset c84c91a4265b0df5c74564039242c7caaef20dc3.