Task #88180

Streamline formatting of html templates

Added by Benjamin Kott 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2019-04-21
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision 149cb289 (diff)
Added by Benjamin Kott 6 months ago

[TASK] Streamline formatting of html templates

The indentations in the HTML templates are out of control.
Even if we provide an EditorConfig, which should ensure
that the files are all uniformly indented. There seems to
have been an increasing aversion to TABS over time.

This has led to the fact that above all newly created templates
have always been indented with SPACES instead of TABS.
We now have a mix of TABS and SPACES in our project, partly
also in a single file.

To avoid this in the future, all existing templates were converted
to indentations with SPACES and the provided EditorConfig was
adapted. In order to really, really make sure that it doesn't get
out of hand, we also introduce a new linter, which ensures
that all HTML templates are properly indented.

Resolves: #88180
Releases: master
Change-Id: I86d23120bc68e3696f398b1ae76f1efc4804d501
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60522
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Oliver Wand <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Helmut Hummel <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60522

#2 Updated by Riccardo De Contardi 6 months ago

  • Category set to Code Cleanup

#3 Updated by Benjamin Kott 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF