Bug #88185

Misleading exception message for BE modules if action not allowed

Added by Sybille Peters about 1 year ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2019-04-23
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The exception message is wrong for modules. Modules are registered in ext_tables.php and not in ext_localconf.php. And it should say "module" and not "plugin".

If the function doesn't know if the action is for a module or plugin, it might be best to mention both.

Reproduce

  1. Create a BE module with Extbase.
  2. Create a new action without allowing it in 2registerModule()
  3. Call the action

Actual result

Exception message: Example

#1313855175 TYPO3\CMS\Extbase\Mvc\Exception\InvalidActionNameException
The action "check" (controller "Something") is not allowed by this plugin. Please check TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin() in your ext_localconf.php.

Expected result

... is not allowed by this plugin / module. Please check configurePlugin in your ext_localconf.php / registerModule in your ext_tables.php.

System details

TYPO3 9.5.5

Associated revisions

Revision 8b22515e (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Clarify Extbase exception message

Ensure that extension developers know where to look when
accessing an inaccessible action from a backend module.

Resolves: #88185
Releases: master, 9.5
Change-Id: I054a93b4162f5b3f2e1dafaf100ed3f9846e4df9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64046
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Tested-by: Benni Mack <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Benni Mack <>

Revision bca432f7 (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Clarify Extbase exception message

Ensure that extension developers know where to look when
accessing an inaccessible action from a backend module.

Resolves: #88185
Releases: master, 9.5
Change-Id: I054a93b4162f5b3f2e1dafaf100ed3f9846e4df9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63979
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64046

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64046

#3 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63979

#4 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63979

#5 Updated by Benni Mack 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF