Task #88213

Update Twitter Bootstrap to v3.4.1

Added by Benni Mack 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
Start date:
2019-04-25
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #88219: Update Twitter Bootstrap to v3.4.1 in Install Tool Closed 2019-04-26

Associated revisions

Revision b4f5e045 (diff)
Added by Benni Mack 4 months ago

[TASK] Raise twitter bootstrap to 3.4.1

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
cd Build
yarn add bootstrap-sass@^3.4.1 --dev
yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Resolves: #88213
Releases: master, 9.5, 8.7
Change-Id: Iae1274b1ca557f6337eea090e39292938b9571f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60556
Tested-by: TYPO3com <>
Tested-by: Mathias Brodala <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Andreas Fernandez <>

Revision c653d84f (diff)
Added by Benni Mack 4 months ago

[TASK] Raise twitter bootstrap to 3.4.1

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
cd Build
yarn add bootstrap-sass@^3.4.1 --dev
yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Resolves: #88213
Releases: master, 9.5, 8.7
Change-Id: Iae1274b1ca557f6337eea090e39292938b9571f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60560
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

Revision 37ef8157 (diff)
Added by Andreas Fernandez 4 months ago

[TASK] Raise twitter bootstrap to 3.4.1

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
cd Build
yarn add bootstrap-sass@^3.4.1 --dev
yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js adding the AMD
factory wrapper.

Resolves: #88213
Releases: master, 9.5, 8.7
Change-Id: Iae1274b1ca557f6337eea090e39292938b9571f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

Revision d6f72d72 (diff)
Added by Andreas Fernandez 4 months ago

[BUGFIX] Let Install Tool use core's bootstrap

The Install Tool ships bootstrap on its own, which doesn't make much sense
right now, since other components get used from EXT:core as well.

For now, the separated bootstrap gets removed and the one of EXT:core is
used instead.

Resolves: #88219
Related: #88213
Releases: master, 9.5, 8.7
Change-Id: I53425f56a44fa9782d7f3776175ac08bc746e5ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60565
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Mathias Brodala <>
Tested-by: Benni Mack <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Benni Mack <>

Revision 2df92f01 (diff)
Added by Andreas Fernandez 4 months ago

[BUGFIX] Let Install Tool use core's bootstrap

The Install Tool ships bootstrap on its own, which doesn't make much sense
right now, since other components get used from EXT:core as well.

For now, the separated bootstrap gets removed and the one of EXT:core is
used instead.

Resolves: #88219
Related: #88213
Releases: master, 9.5, 8.7
Change-Id: I53425f56a44fa9782d7f3776175ac08bc746e5ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60618
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

Revision 5bc663f1 (diff)
Added by Benni Mack 4 months ago

[BUGFIX] Let Install Tool use core's bootstrap

The Install Tool ships bootstrap on its own, which doesn't make much sense
right now, since other components get used from EXT:core as well.

For now, the separated bootstrap gets removed and the one of EXT:core is
used instead.

Resolves: #88219
Related: #88213
Releases: master, 9.5, 8.7
Change-Id: I53425f56a44fa9782d7f3776175ac08bc746e5ab
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60619
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60556

#2 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60560

#3 Updated by Benni Mack 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review 4 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564

#5 Updated by Andreas Fernandez 4 months ago

  • Related to Bug #88219: Update Twitter Bootstrap to v3.4.1 in Install Tool added

#6 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564

#7 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564

#8 Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564

#9 Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564

#10 Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60564

#11 Updated by Andreas Fernandez 4 months ago

  • Status changed from Under Review to Resolved

#12 Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF