Project

General

Profile

Actions

Bug #88221

closed

Extbase FileReference cannot be used in ImageService because of too strict typehint

Added by Susanne Moog about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2019-04-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

While hardening the ImageService it was restricted to core's FileReference instead of also allowing extbase FileReferences - the code for converting them is still there but not reachable anymore due to the restrictive type hint.

To test:

- Create an '\TYPO3\CMS\Extbase\Domain\Model\FileReference' and call ImageService::getImage('', $image...)

Easy core steps:
- Use the form framework to create a form with an image upload field.
- Add a summary page to the form
- Use the form in frontend and upload an image - get the error when looking at the summary
[note: after applying the patch you will get a second error because of changed meta data handling, however that's a separate issue]


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #88222: ImageViewHelper uses properties without checking existanceClosedSusanne Moog2019-04-26

Actions
Actions #1

Updated by Gerrit Code Review about 5 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60567

Actions #2

Updated by Mathias Brodala about 5 years ago

  • Related to Bug #88222: ImageViewHelper uses properties without checking existance added
Actions #3

Updated by Anonymous about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack about 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF