Bug #88408
closedAbstractButtonViewHelper ignores option 'showLabel'
100%
Description
TYPO3 v9.5 (introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/51091)
<be:moduleLayout.button.linkButton icon="actions-open" title="..." link="..." showLabel="true" />
TYPO3\CMS\Backend\ViewHelpers\ModuleLayout\Button\AbstractButtonViewHelper initializes the argument showLabel ("Defines whether to show the title as a label within the button"), but this argument is not applied to $button
. Thus the button is always rendered as "icon only" (without label text).
See line 90 AbstractButtonViewHelper::addDefaultAttributes()
private static function addDefaultAttributes(AbstractButton $button, array $arguments, RenderingContextInterface $renderingContext): void { if (isset($arguments['title'])) { $button->setTitle($arguments['title']); } /** @var ModuleTemplate $moduleTemplate */ $moduleTemplate = $renderingContext->getViewHelperVariableContainer()->get(ModuleLayoutViewHelper::class, ModuleTemplate::class); $button->setIcon($moduleTemplate->getIconFactory()->getIcon($arguments['icon'], Icon::SIZE_SMALL)); }
- if (isset($arguments['title'])) { - $button->setTitle($arguments['title']); - } + if (isset($arguments['title'])) { + $button->setTitle($arguments['title']); + } + if (isset($arguments['showLabel'])) { + $button->setShowLabelText($arguments['showLabel']); + }
Updated by Georg Tiefenbrunn over 5 years ago
- Related to Bug #85532: Convert backend user module to use view helpers for configuring module layout added
Updated by Georg Ringer over 5 years ago
- Category set to Backend API
- Status changed from New to Accepted
- Assignee set to Georg Ringer
- Target version set to next-patchlevel
- Complexity set to easy
Updated by Gerrit Code Review over 5 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60789
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60796
Updated by Georg Ringer over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 01626d643a66e8102996f69b3ba0b58382682447.