Task #88667

Remove additionalJavaScriptSubmit

Added by Andreas Fernandez 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-07-01
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

With TYPO3 7, RequireJS was introduced into Core and thus into FormEngine. However, it's still possible to load inline JavaScript that is executed when the form is submitted. This approach is not required anymore.


Related issues

Related to TYPO3 Core - Bug #88728: Modal for unfilled fields not shown anymore Closed 2019-07-11

Associated revisions

Revision 66302a14 (diff)
Added by Andreas Fernandez 11 months ago

[!!!][TASK] Remove `additionalJavaScriptSubmit` from FormEngine

With RequireJS in place, it is possible to minimize the amount of inline
JavaScript in the backend. This patch removes FormEngine's
`additionalJavaScriptSubmit` feature that registers additional submit
handlers and allows to abort the form submission.

This feature is rarely used at all, but can be achieved using a RequireJS
module that registers a callback in `TYPO3/CMS/Backend/DocumentSaveActions`.

Since the feature is gone, a lot of global code within TBE_EDITOR is
removed as well.

Resolves: #88667
Releases: master
Change-Id: I92f26aa52cafab5df30a706ea95f1e1702a4a778
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60861
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Tested-by: Frank Naegler <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Oliver Hader <>
Reviewed-by: Frank Naegler <>

Revision 83aa178e (diff)
Added by Andreas Fernandez 11 months ago

[BUGFIX] Render modal if form is invalid

The removed code in tbe_editor.js as in #88667 contained some special
handling for invalid forms. In case a form was considered invalid, a
modal was rendered explaining to check the form.

This code is now added again in FormEngine's validation module as
a DocumentSaveAction callback.

Resolves: #88728
Related: #88667
Releases: master
Change-Id: I221da830ac33a2f92480bdc933374850bcc35c11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61273
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Frank Naegler <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review 11 months ago

  • Status changed from In Progress to Under Review

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60861

#2 Updated by Gerrit Code Review 11 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60861

#3 Updated by Gerrit Code Review 11 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60861

#4 Updated by Andreas Fernandez 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Andreas Fernandez 11 months ago

  • Related to Bug #88728: Modal for unfilled fields not shown anymore added

#6 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF