Bug #88728

Modal for unfilled fields not shown anymore

Added by Andreas Fernandez 12 days ago. Updated 12 days ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-07-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

If a form rendered by FormEngine has fields violating any constraints, a modal saying "The fields marked with an exclamation mark are not yet correctly filled in. Please complete them properly." should get rendered on a save attempt. This is not the case anymore.


Related issues

Related to TYPO3 Core - Task #88667: Remove additionalJavaScriptSubmit Closed 2019-07-01

Associated revisions

Revision 83aa178e (diff)
Added by Andreas Fernandez 12 days ago

[BUGFIX] Render modal if form is invalid

The removed code in tbe_editor.js as in #88667 contained some special
handling for invalid forms. In case a form was considered invalid, a
modal was rendered explaining to check the form.

This code is now added again in FormEngine's validation module as
a DocumentSaveAction callback.

Resolves: #88728
Related: #88667
Releases: master
Change-Id: I221da830ac33a2f92480bdc933374850bcc35c11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61273
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Frank Naegler <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Frank Naegler <>

History

#1 Updated by Andreas Fernandez 12 days ago

  • Related to Task #88667: Remove additionalJavaScriptSubmit added

#2 Updated by Gerrit Code Review 12 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61273

#3 Updated by Gerrit Code Review 12 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61273

#4 Updated by Gerrit Code Review 12 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61273

#5 Updated by Andreas Fernandez 12 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF