Task #88693

Remove unneeded SingletonInstance resets in recent extbase tests

Added by Benjamin Franzke 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Start date:
2019-07-05
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

These were introduced with the recent extbase configuration manager hardening https://review.typo3.org/c/Packages/TYPO3.CMS/+/59624 but are not needed, because there are no singletons triggered via makeInstance in these tests.


Related issues

Related to TYPO3 Core - Task #87628: Harden \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface Closed 2019-02-02

Associated revisions

Revision 3a2e6b2f (diff)
Added by Benjamin Franzke 3 months ago

[TASK] Remove unneeded SingletonInstance resets in recent extbase tests

These were introduced with the recent extbase configuration manager
hardening but are not needed, because there are no singletons
triggered via makeInstance in these tests.

Change-Id: Iae4d55acd8a02997dd8fc256231c39503a8cfc88
Resolves: #88693
Related: #87628
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61234
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Benjamin Franzke 3 months ago

  • Related to Task #87628: Harden \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface added

#2 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61234

#3 Updated by Benjamin Franzke 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF