Task #87628

Epic #87594: Harden extbase

Harden \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface

Added by Alexander Schnitzler 7 months ago. Updated 29 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-02-02
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #88693: Remove unneeded SingletonInstance resets in recent extbase tests Closed 2019-07-05

Associated revisions

Revision 211781a1 (diff)
Added by Alexander Schnitzler about 2 months ago

[!!!][TASK] Harden extbase configuration managers

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87628
Change-Id: I97ccf3d4ca66828efbb59b49786eb69e7de3c925
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59624
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Frank Naegler <>
Reviewed-by: Benni Mack <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Frank Naegler <>

Revision 3a2e6b2f (diff)
Added by Benjamin Franzke about 2 months ago

[TASK] Remove unneeded SingletonInstance resets in recent extbase tests

These were introduced with the recent extbase configuration manager
hardening but are not needed, because there are no singletons
triggered via makeInstance in these tests.

Change-Id: Iae4d55acd8a02997dd8fc256231c39503a8cfc88
Resolves: #88693
Related: #87628
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61234
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59624

#2 Updated by Gerrit Code Review about 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59624

#3 Updated by Gerrit Code Review about 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59624

#4 Updated by Anonymous about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benjamin Franzke about 2 months ago

  • Related to Task #88693: Remove unneeded SingletonInstance resets in recent extbase tests added

#6 Updated by Benni Mack 29 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF