Task #88800

Epic #83968: PSR-11 Initiative

Use dependency injection in PSR-15 middlewares

Added by Benjamin Franzke 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
System/Bootstrap/Configuration
Start date:
2019-07-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision f1bf354c (diff)
Added by Benjamin Franzke 3 months ago

[TASK] Use dependency injection in middlewares

Use constructor injection for middleware dependencies, moving away
from GeneralUtility::makeInstance based Singleton lookup.
Dependencies which are already configured to be optionally
injectable via constructor arguments (e.g. for unit tests) are
changed to be required constructor arguments. Since the introduction of
symfony dependency injection the fallback to GeneralUtility::makeInstance
is no longer used – therefore it is dropped.

Releases: master
Resolves: #88800
Change-Id: I6dbec2f91fc78c1b06dd179323fb7a4810c13baa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Daniel Goerz <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322

#4 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322

#5 Updated by Benjamin Franzke 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF