Bug #88898

Add test for set HTTP_HOST, HTTP_X_FORWARDED_HOST + reverseProxyIP

Added by Jonas Eberle 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2019-08-02
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
CodingNight
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

IMHO 1 case is not covered.

It is very close to

            'first HTTP_X_FORWARDED_HOST from configured proxy' => [
                [
                    'HTTP_HOST' => '',
                    'REMOTE_ADDR' => '123.123.123.123',
                    'HTTP_X_FORWARDED_HOST' => 'www.domain1.com, www.domain2.com,'
                ],
                [
                    'reverseProxyIP' => '123.123.123.123',
                    'reverseProxyHeaderMultiValue' => 'first',
                ],
                'www.domain1.com',
            ],

, but with a set HTTP_HOST. The result shall be the same.

Associated revisions

Revision c56abd72 (diff)
Added by Jonas Eberle about 1 month ago

[TASK] Add test case for reverse proxy configuration

The case covers given HTTP_HOST and HTTP_X_FORWARDED_HOST with
a configuration for an (intransparent) proxy.

As some reverse proxies can be configured to have a rewritten HTTP_HOST
(usually some internal name that matches the virtual host config on the
webserver) I wondered if I can safely assume that TYPO3 handles that.

Resolves: #88898
Releases: master
Change-Id: I05302afdea0366674748445808ff00a48716e7f8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404
Tested-by: TYPO3com <>
Tested-by: Jonas Eberle <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Jonas Eberle <>
Reviewed-by: Benjamin Franzke <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404

#4 Updated by Susanne Moog 3 months ago

  • Tags set to CodingNight

#5 Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404

#6 Updated by Anonymous about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF