Bug #89011

InvalidArgumentException due to ActionController property annotation

Added by Sebastian Fischer 29 days ago. Updated 28 days ago.

Status:
Resolved
Priority:
Must have
Category:
Extbase
Start date:
2019-08-25
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In the ActionController a property annotation causes an InvalidArgumentException in \phpDocumentor\Reflection\Fqsen::__construct. By removing the semicolon at the end of HashService this exception does not appear anymore.

/**
 * @var HashService;
*/
protected $hashService;

Associated revisions

Revision c4eb6a56 (diff)
Added by Alexander Schnitzler 28 days ago

[BUGFIX] Remove superfluous comma in ActionController

https://review.typo3.org/c/Packages/TYPO3.CMS/+/61235
introduced a superfluous trailing comma, which leads to an
InvalidArgument exception, thrown by the phpDocumentor annoation parser.

The InvalidArgument exception is actually already handled in
PhpDocPropertyTypeExtractor::getDocBlockFromProperty, but other code
that uses phpdocumentator directly would be affected.

Releases: master
Resolves: #89011
Change-Id: Ia424b76871e0637eeed6a0330f6f408359720bd1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61556
Tested-by: TYPO3com <>
Tested-by: Guido Schmechel <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Benjamin Franzke <>

History

#1 Updated by Alexander Schnitzler 28 days ago

  • Status changed from New to Accepted
  • Assignee set to Alexander Schnitzler
  • Priority changed from Should have to Must have
  • Is Regression set to Yes

#2 Updated by Gerrit Code Review 28 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61556

#3 Updated by Benjamin Franzke 28 days ago

Fully agree, that this is a bug, but one question, can you provide a backtrace?

I don't see where this Exception is actually triggered in core.
The InvalidArgument Exception is catched in https://github.com/TYPO3/TYPO3.CMS/blob/a73ba8f9f8ecd75d7fff59dfa992262ba0db49d2/typo3/sysext/extbase/Classes/Reflection/PropertyInfo/Extractor/PhpDocPropertyTypeExtractor.php#L117

Does this Exception happen in regular ActionController dispatches, or do you use phpDocumentor/reflection directly in own code?

#4 Updated by Gerrit Code Review 28 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61556

#5 Updated by Anonymous 28 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF