Project

General

Profile

Actions

Bug #89057

closed

Altering the arguments of a schedulable Symfony command that is configured in the Scheduler module breaks the module

Added by Stefan P over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
scheduler
Target version:
-
Start date:
2019-09-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

  1. Create a Symfony Command with arguments and register it.
  2. In teh Scheduler module add a task to execute console commands and select your command, save
  3. Remove one argument in the code again
  4. Open the Scheduler module
  5. Exception "The <removed argument name> argument does not exist."

No way to recover from this via backend.

Problem is in sysext:scheduler/Classes/Task/ExecuteSchedulableCommandTask.php on line 113 where $input = new ArrayInput($this->getArguments(), $schedulableCommand->getDefinition()); is called. The defintion is read by Symfony fron the actual PHP file of the command, but the arguments are read from the additonal fields.

Some check whether the defintion has changed against the stored arguments has to happen there. Without such a check changing an existing task is basically not possible without breaking the scheduler (inducing manually fixing scheduler tasks via DB, not even a console command exists to fix such a state).

Actions #1

Updated by Stefan P over 4 years ago

  • Subject changed from Altering the arguments of a schedulable Symfony command that is configured in teh Scheduler module breaks the module to Altering the arguments of a schedulable Symfony command that is configured in the Scheduler module breaks the module
Actions #2

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63599

Actions #3

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63578

Actions #4

Updated by Susanne Moog about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF