Bug #89092

Type "checkbox" within FlexForm sections

Added by Martin Ellinger 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2019-09-05
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After TYPO3 Update from 7.6 to 9.5 it is no longer possible to use a checkbox within FlexForm sections. If u add multiple inline-entries all checkboxes get the same id. If u click on a checkbox the first one is triggered all the time.

Example FlexForm config

<T3DataStructure>
    <meta type="array">
        <langDisable>1</langDisable>
    </meta>
    <sheets>
        <template>
            <ROOT>
                <TCEforms>
                    <sheetTitle>Template</sheetTitle>
                </TCEforms>
                <type>array</type>
                <el>
                    <settings.modules>
                        <section>1</section>
                        <title>Module</title>
                        <type>array</type>
                        <el type="array">
                            <module>
                                <title>Modul</title>
                                <type>array</type>
                                <el type="array">
                                    <modulname>
                                        <TCEforms type="array">
                                            <label>Modulname</label>
                                            <config type="array">
                                                <type>input</type>
                                                <size>50</size>
                                            </config>
                                        </TCEforms>
                                    </modulname>
                                    <availability>
                                        <TCEforms type="array">
                                            <label>Verfügbarkeit</label>
                                            <config type="array">
                                                <type>check</type>
                                                <default>0</default>
                                            </config>
                                        </TCEforms>
                                    </availability>
                                </el>
                            </module>
                        </el>
                    </settings.modules>
                </el>
            </ROOT>
        </template>
    </sheets>
</T3DataStructure>

Related issues

Related to TYPO3 Core - Bug #88923: Ticking a checkbox in a section will affect only the first element to be changed Closed 2019-08-05
Related to Dynamic Content Elements (DCE) - Bug #89179: Checkbox in Section click-Event Rejected 2019-09-16
Related to TYPO3 Core - Bug #87429: Same checkbox in different sections can't be selected indipendently Under Review 2019-01-14

Associated revisions

Revision f0bff592 (diff)
Added by Georg Ringer 2 months ago

[BUGFIX] Generate unique id for checkboxes in flexform sections

Use a checksum of the element's name as additional identifier to generate
an unique id for checkboxes in flexform sections.

Resolves: #89092
Releases: master, 9.5
Change-Id: I57075aba05c8de23cbdacfff3a05b63eb71499c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61911
Tested-by: TYPO3com <>
Tested-by: Sascha Rademacher <>
Tested-by: Christian Eßl <>
Tested-by: Jörg Bösche <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Christian Eßl <>
Reviewed-by: Julian Geils <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Armin Vieweg <>
Reviewed-by: Andreas Fernandez <>

Revision 228c8175 (diff)
Added by Georg Ringer 2 months ago

[BUGFIX] Generate unique id for checkboxes in flexform sections

Use a checksum of the element's name as additional identifier to generate
an unique id for checkboxes in flexform sections.

Resolves: #89092
Releases: master, 9.5
Change-Id: I57075aba05c8de23cbdacfff3a05b63eb71499c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61922
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Martin Ellinger 3 months ago

  • Description updated (diff)
  • Category set to FormEngine aka TCEforms

#2 Updated by Georg Ringer 2 months ago

  • Status changed from New to Accepted

#3 Updated by Gerrit Code Review 2 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61911

#4 Updated by Georg Ringer 2 months ago

to test this behaviour, just add the mentioned flexform snippet to EXT:felogin/Configuration/FlexForms/Login.xml

#5 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61911

#6 Updated by Georg Ringer 2 months ago

  • Related to Bug #88923: Ticking a checkbox in a section will affect only the first element to be changed added

#7 Updated by Georg Ringer 2 months ago

  • Related to Bug #89179: Checkbox in Section click-Event added

#8 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61922

#9 Updated by Georg Ringer 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Dima Nozdrin about 2 months ago

  • Related to Bug #87429: Same checkbox in different sections can't be selected indipendently added

Also available in: Atom PDF