Bug #89180

Remove sys_file_metadata width and height from excludefields

Added by Christian Futterlieb about 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2019-09-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

The fields sys_file_metadata.width and sys_file_metadata.height are marked as readOnly. But they are excludeField too.

Even though this is not a logical combination at all, it wouldn't hurt much so far. Until now, when a user tried to translate a sys_file_metadata record and the width and height (which she did not have access to) fields are then set to zero (which then effectively disabled the crop config for the translation of the record to be rendered).

I'd suggest to just remove the 'exclude' => true from those two fields from sysext core and filemetadata. The height/width are managed internally anyway (for example when a user uploads an image the width/height are set correctly even though the user has no access according to the excludeFields). The visibility of the cols should be left to the typedef.


Related issues

Related to TYPO3 Core - Bug #81964: No crop information given in localized FAL version If translated meta data is provided Closed 2017-07-25

Associated revisions

Revision 6afc789f (diff)
Added by Susanne Moog 8 months ago

[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata

Width and height are readonly fields updated by system image service API.
To ensure the API (for example the crop wizard) works flawlessly for
editors out of the box, width and height are no longer exclude fields.

Releases: 9.5
Resolves: #89180
Change-Id: I53f6c5353f0a8d629a9d209675a19def2d6c7a60
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467
Tested-by: TYPO3com <>
Tested-by: Stefan Froemken <>
Tested-by: Oliver Bartsch <>
Tested-by: Georg Ringer <>
Reviewed-by: Stefan Froemken <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Christian Futterlieb about 1 year ago

I just saw: this is resolved by #81964, but for master only. Is there any chance we could get this for v8 and v9 too?

#2 Updated by Christian Futterlieb about 1 year ago

  • Related to Bug #81964: No crop information given in localized FAL version If translated meta data is provided added

#3 Updated by Georg Ringer about 1 year ago

  • Status changed from New to In Progress

will check if a backport will be done.

#4 Updated by Georg Ringer 8 months ago

  • Assignee set to Georg Ringer

#5 Updated by Georg Ringer 8 months ago

  • Status changed from In Progress to Accepted
  • TYPO3 Version changed from 8 to 9

#6 Updated by Gerrit Code Review 8 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467

#7 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467

#8 Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467

#9 Updated by Anonymous 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF