Project

General

Profile

Actions

Bug #89180

closed

Remove sys_file_metadata width and height from excludefields

Added by Christian Futterlieb over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2019-09-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

The fields sys_file_metadata.width and sys_file_metadata.height are marked as readOnly. But they are excludeField too.

Even though this is not a logical combination at all, it wouldn't hurt much so far. Until now, when a user tried to translate a sys_file_metadata record and the width and height (which she did not have access to) fields are then set to zero (which then effectively disabled the crop config for the translation of the record to be rendered).

I'd suggest to just remove the 'exclude' => true from those two fields from sysext core and filemetadata. The height/width are managed internally anyway (for example when a user uploads an image the width/height are set correctly even though the user has no access according to the excludeFields). The visibility of the cols should be left to the typedef.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81964: No crop information given in localized FAL version If translated meta data is providedClosed2017-07-25

Actions
Actions #1

Updated by Christian Futterlieb over 4 years ago

I just saw: this is resolved by #81964, but for master only. Is there any chance we could get this for v8 and v9 too?

Actions #2

Updated by Christian Futterlieb over 4 years ago

  • Related to Bug #81964: No crop information given in localized FAL version If translated meta data is provided added
Actions #3

Updated by Georg Ringer over 4 years ago

  • Status changed from New to In Progress

will check if a backport will be done.

Actions #4

Updated by Georg Ringer about 4 years ago

  • Assignee set to Georg Ringer
Actions #5

Updated by Georg Ringer about 4 years ago

  • Status changed from In Progress to Accepted
  • TYPO3 Version changed from 8 to 9
Actions #6

Updated by Gerrit Code Review about 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467

Actions #7

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467

Actions #8

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63467

Actions #9

Updated by Anonymous about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF