Bug #89182

Epic #85006: Reduce falsely reported broken links

Linkvalidator should only check relevant fields in table

Added by Sybille Peters over 1 year ago. Updated 6 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2019-09-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Some checks should only be performed if content is relevant.

For example:

tt_content.bodytext : depends on ctype (e.g. is usually not relevant for plugins)
pages.url : depends on doktype

The problem is currently, if page or content element types are changed, the content is not removed from the fields which are now no longer relevant, so in older sites where this had been changed, you may get a lot of "broken links" for content that is not rendered in FE and is irrelevant.

h2 Reproduce

  1. Create a content element, e.g. "text & media"
  2. Add a broken link to the content (tt_content.bodytext)
  3. Now change the content type, e.g. to plugin
  4. We recheck for broken links for that page
  5. We look at linkvalidator report

Actual result

The broken link will be displayed

Expected result

The broken link in the element "plugin" should not be displayed, because tt_content.bodytext is not relevant if content type is plugin

Possible solution

It should be possible to get the information, which fields are editable via TCA: 'interface' => 'showRecordFieldList'.


Related issues

Related to TYPO3 Core - Feature #89177: Change TsConfig Defaults of Linkvalidator and Enable all core fields containing linksNew2019-09-15

Actions
Related to TYPO3 Core - Bug #84214: Linkvalidator should not check records without write permissionsClosedSybille Peters2018-03-12

Actions
Related to TYPO3 Core - Feature #92542: Linkvalidator should check shortcut pagesNew2020-10-12

Actions
#1

Updated by Sybille Peters over 1 year ago

  • Related to Feature #89177: Change TsConfig Defaults of Linkvalidator and Enable all core fields containing links added
#2

Updated by Georg Ringer over 1 year ago

  • Description updated (diff)
#3

Updated by Sybille Peters over 1 year ago

  • Description updated (diff)
#4

Updated by Sybille Peters over 1 year ago

  • Related to Bug #84214: Linkvalidator should not check records without write permissions added
#5

Updated by Sybille Peters over 1 year ago

  • Subject changed from Extend TSconfig configuration to allow restrictions (where) for fields to Linkvalidator should only check relevant fields in table
#6

Updated by Sybille Peters over 1 year ago

  • Parent task set to #85006
#7

Updated by Sybille Peters 8 months ago

  • Tracker changed from Feature to Bug
  • Description updated (diff)
  • TYPO3 Version set to 9
#8

Updated by Sybille Peters 8 months ago

  • Description updated (diff)
#9

Updated by Sybille Peters 8 months ago

  • Related to Feature #92542: Linkvalidator should check shortcut pages added
#10

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#11

Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#12

Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#13

Updated by Gerrit Code Review 7 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#14

Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#15

Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#16

Updated by Gerrit Code Review 7 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#17

Updated by Gerrit Code Review 6 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

#18

Updated by Gerrit Code Review 6 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66651

Also available in: Atom PDF