Project

General

Profile

Actions
Copy link

Bug #89187

closed

Slug recreation is not available for generator fields with type=inline

Added by Elias Häußler over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2019-09-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Issue

If a element of type=slug has a single generator field with type=inline defined, Slug recreation in the Form engine is not possible. This is because the recreation button will be disabled if the generator fields are not available for proposal generation.

Repro

Create a field with the following configuration and make it visible in the backend:

'slug' => [
    'exclude' => true,
    'label' => 'LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:pages.slug',
    'config' => [
        'type' => 'slug',
        'size' => 50,
        'generatorOptions' => [
            'fields' => ['image'],
            'fieldSeparator' => '/',
            'prefixParentPageSlug' => true,
        ],
        'fallbackCharacter' => '-',
        'eval' => 'uniqueInSite',
        'default' => '',
    ],
],

Now make sure you have a field with type=inline and name "image".

Check in backend if the recreate button next to the slug field is disabled (see attachment).

Files

Download all files
Bildschirmfoto 2019-09-17 um 11.45.52.png (4.32 KB) Bildschirmfoto 2019-09-17 um 11.45.52.png Elias Häußler, 2019-09-17 13:08
test_89187_1.0.0_201909232221.zip (1.82 KB) test_89187_1.0.0_201909232221.zip Test extension to reproduce issue Joerg Kummer, 2019-09-23 22:22

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #90141: Slug recreation is not availabe for generator fields that are configured as "readonly"Closed2020-01-17

Actions
Actions
Copy link
 #1

Updated by Elias Häußler over 4 years ago

  • Subject changed from Slug recreation is not available for generator fields with type=group to Slug recreation is not available for generator fields with type=inline
  • Description updated (diff)
Actions
Copy link
 #2

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #3

Updated by Joerg Kummer over 4 years ago

To reproduce this issue, I'll post a test case as extension where you should have a look at ext_tables.php to create mentioned scenario on slug element for pages.
It requires that you set some entries for pages.media

Actions
Copy link
 #4

Updated by Elias Häußler over 4 years ago

Joerg Kummer wrote:

To reproduce this issue, I'll post a test case as extension where you should have a look at ext_tables.php to create mentioned scenario on slug element for pages.
It requires that you set some entries for pages.media

Thanks for your input, Jörg.

Actions
Copy link
 #5

Updated by David Rellstab over 4 years ago

  • Related to Bug #90141: Slug recreation is not availabe for generator fields that are configured as "readonly" added
Actions
Copy link
 #6

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #7

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #8

Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #9

Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #10

Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #11

Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #12

Updated by Gerrit Code Review about 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #13

Updated by Gerrit Code Review about 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #14

Updated by Gerrit Code Review about 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #15

Updated by Gerrit Code Review almost 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #16

Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #17

Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #18

Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #19

Updated by Gerrit Code Review over 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #20

Updated by Gerrit Code Review over 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #21

Updated by Gerrit Code Review over 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716

Actions
Copy link
 #22

Updated by Oliver Bartsch over 3 years ago

Can be tested like:

// Overrides/pages.php

$GLOBALS['TCA']['pages']['columns']['slug']['config']['generatorOptions']['fields'] = [];
$GLOBALS['TCA']['pages']['columns']['slug']['config']['generatorOptions']['postModifiers'] = [\Vendor\Ext\Hooks\SlugPostModifier::class . '->modify'];

Or just disable defined fields in TSconfig:

TCEFORM.pages.title.disabled = 1

And the hook just adds a postfix

// Hooks/SlugPostModifier.ph
class SlugPostModifier
{
    public function modify($parameters, SlugHelper $slugHelper): string
    {
        return $parameters['slug'] . '-slugPostFix';
    }
}
Actions
Copy link
 #23

Updated by Anonymous over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #24

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66415

Actions
Copy link
 #25

Updated by Anonymous over 3 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #26

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review
Actions
Copy link
 #27

Updated by Benni Mack over 3 years ago

  • Status changed from Under Review to Closed
Actions
Copy link

Also available in: Atom PDF