Bug #89378

Preprossing of URLs for conversion to punycode truncates some URLs

Added by Sybille Peters 11 days ago. Updated 9 days ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2019-10-08
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The function ExternalLinktype::preprocessUrl truncates some URLs into an empty string.

The function was originally introduced in order to enable URLs with Umlaut in domains, e.g. https://äh.de

These are some of the URLs the function converts into empty strings:

https://www.nbank.de/Unternehmen/Ausbildung-Qualifikation/Weiterbildung-in-Niedersachsen/
https://www.oldenburg.de/startseite/wirtschaft/wirtschaftsfoerderung/beratung-foerderung/gruenderberatung/gruenderforen.html
http://www.nwzonline.de/tv?bcpid=1701167454001&bckey=AQ~~,AAAAAGL7LqU~,aXlKNnCf9d9Tmck-kOc4PGFfCgHjM5JR&bctid=1040702768001
http://www.uni-bremen.de/universitaet/die-uni-im-ueberblick/lageplan/gebaeude/building/120


These will then falsely be reported as broken links.

The function preprocessUrl was originally introduced to handle domains with special characters, see #55155

Associated revisions

Revision 62575836 (diff)
Added by Sybille Peters 9 days ago

[BUGFIX] Fix preprocessing of external URLs in linkvalidator

Fix the preprocessing of external URLs that was originally
introduced to handle domains with special characters (conversion
to punycode). The previous functionality had the unintended side
effect of truncating some URLs to empty strings and leading to
falsely reported broken links.

Resolves: #89378
Releases: master, 9.5
Change-Id: Ifbca076342fd04d758d2dd1a2ae2f7487751d58c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Sascha Rademacher <>
Tested-by: Julian Geils <>
Tested-by: Daniel Goerz <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Felix P. <>
Reviewed-by: Julian Geils <>
Reviewed-by: Daniel Goerz <>

Revision 76877807 (diff)
Added by Sybille Peters 9 days ago

[BUGFIX] Add unit test for linkvalidator (preprocessUrl)

Resolves: #89378
Releases: master, 9.5
Change-Id: Ifbca076342fd04d758d2dd1a2ae2f7487751d58c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61943
Tested-by: Jörg Bösche <>
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review 11 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#2 Updated by Sybille Peters 11 days ago

  • Status changed from Under Review to New
  • Priority changed from Should have to Must have

#3 Updated by Sybille Peters 11 days ago

  • Description updated (diff)

#4 Updated by Sybille Peters 11 days ago

  • Description updated (diff)

#5 Updated by Gerrit Code Review 11 days ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#6 Updated by Gerrit Code Review 10 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#7 Updated by Gerrit Code Review 10 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#8 Updated by Gerrit Code Review 10 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#9 Updated by Gerrit Code Review 10 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#10 Updated by Sybille Peters 10 days ago

  • Description updated (diff)

#11 Updated by Sybille Peters 9 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Gerrit Code Review 9 days ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61943

#13 Updated by Gerrit Code Review 9 days ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61943

#14 Updated by Sybille Peters 9 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF