Bug #89378

Preprossing of URLs for conversion to punycode truncates some URLs

Added by Sybille Peters almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2019-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The function ExternalLinktype::preprocessUrl truncates some URLs into an empty string.

The function was originally introduced in order to enable URLs with Umlaut in domains, e.g. https://äh.de

These are some of the URLs the function converts into empty strings:

https://www.nbank.de/Unternehmen/Ausbildung-Qualifikation/Weiterbildung-in-Niedersachsen/
https://www.oldenburg.de/startseite/wirtschaft/wirtschaftsfoerderung/beratung-foerderung/gruenderberatung/gruenderforen.html
http://www.nwzonline.de/tv?bcpid=1701167454001&bckey=AQ~~,AAAAAGL7LqU~,aXlKNnCf9d9Tmck-kOc4PGFfCgHjM5JR&bctid=1040702768001
http://www.uni-bremen.de/universitaet/die-uni-im-ueberblick/lageplan/gebaeude/building/120


These will then falsely be reported as broken links.

The function preprocessUrl was originally introduced to handle domains with special characters, see #55155

#1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#2

Updated by Sybille Peters almost 2 years ago

  • Status changed from Under Review to New
  • Priority changed from Should have to Must have
#3

Updated by Sybille Peters almost 2 years ago

  • Description updated (diff)
#4

Updated by Sybille Peters almost 2 years ago

  • Description updated (diff)
#5

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#6

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#7

Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#8

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#9

Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61910

#10

Updated by Sybille Peters almost 2 years ago

  • Description updated (diff)
#11

Updated by Sybille Peters almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#12

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61943

#13

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61943

#14

Updated by Sybille Peters almost 2 years ago

  • Status changed from Under Review to Resolved
#15

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF