Bug #89388

Add flash message container to "Sorry, you didn't have proper permissions to perform this change." error message

Added by Christian Eßl 9 days ago. Updated 6 days ago.

Status:
Resolved
Priority:
Should have
Category:
Backend User Interface
Target version:
-
Start date:
2019-10-10
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If a normal editor tries to edit a record which he has no reason to, the EditFormController will show an error message like:

Sorry, you didn't have proper permissions to perform this change.
ERROR: Language was not allowed.

Unlike most other parts of the backend, this error is currently shown as plain text and not with an error flashmessage container (like the one used in InfoboxViewHelper)
As EditFormController does not use fluid at all, using the InfoboxViewHelper is not viable here. - I would just write a simple Helper-Function for wrapping the errors in a flash message html container.

Associated revisions

Revision 2e91d9a3 (diff)
Added by Christian Eßl 6 days ago

[TASK] Style error message on trying to access a restricted record

If editors try to edit a record, which they have no access to, the
EditFormController will show an error message like:

"Sorry, you didn't have proper permissions to perform this change."

plus an explanation why accessing the record failed. Unlike most other
parts of the backend, this error was only shown as plain text without
a flash message html container as styling.

Resolves: #89388
Releases: master
Change-Id: I514d0cedf9690a0de0695bef309ea37703429ca8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61957
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Daniel Goerz <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Georg Ringer 9 days ago

  • Assignee set to Christian Eßl

#2 Updated by Georg Ringer 9 days ago

  • Status changed from New to Accepted

#3 Updated by Gerrit Code Review 8 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61957

#4 Updated by Gerrit Code Review 7 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61957

#5 Updated by Christian Eßl 6 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF