Bug #89599

Restore element in draft workspace - wrong button label

Added by Riccardo De Contardi 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2019-11-06
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Prerequisites

1) TYPO3 installation 10.2.0-dev (latest master)
2) A custom "Draft" Workspace

Test procedure:

1) LIVE workspace > create a content element in a page
2) switch to Draft workspace
3) switch to List View
4) Delete the content element created at point 1) using the trash button in list view
4.1) Result: the list is updated and the CE removed
5) Click again on the same page in the pageTree
5.1) Result: the list shows again the deleted content element , but now the trash button has the "restore" symbol on it (circled arrows) and it is used to restore the element
6) Click on it to restore the element

Result: a popup appears: see the attached image:

The "Delete" button actually restores the record, so its label is wrong and should be Restore instead.

Note: Also affects 9.5.11

Cattura2.png View (45.8 KB) Riccardo De Contardi, 2019-11-06 23:06


Related issues

Related to TYPO3 Core - Bug #52700: Change delete icon in context menu if record is deleted Under Review 2013-10-06 2013-10-06

Associated revisions

Revision 7b5252dd (diff)
Added by Georg Ringer 3 months ago

[BUGFIX] Use correct label while restoring a record in workspace

If a record should be restored, the label in the modal must be set to
"Restore record" instead of "Delete".

Resolves: #89599
Releases: master, 9.5
Change-Id: I201473cb86be207cda9c87b43c5420f6cb5c6898
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63244
Tested-by: TYPO3com <>
Tested-by: Stefan Froemken <>
Tested-by: Riccardo De Contardi <>
Tested-by: Benni Mack <>
Reviewed-by: Stefan Froemken <>
Reviewed-by: Benni Mack <>

Revision e8cab9eb (diff)
Added by Georg Ringer 3 months ago

[BUGFIX] Use correct label while restoring a record in workspace

If a record should be restored, the label in the modal must be set to
"Restore record" instead of "Delete".

Resolves: #89599
Releases: master, 9.5
Change-Id: I201473cb86be207cda9c87b43c5420f6cb5c6898
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63220
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63244

#2 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63220

#3 Updated by Georg Ringer 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

#5 Updated by Georg Ringer 3 months ago

  • Related to Bug #52700: Change delete icon in context menu if record is deleted added

Also available in: Atom PDF