Task #89613

Do not add target on image link when lightbox is enabled

Added by Eric Chavaillaz 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2019-11-08
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

If lightbox is enabled and per example config.fileTarget is set to "_blank", the target is added in the click enlarge links and it make no sense.

I think the target must not be added in this context.

Associated revisions

Revision 41fc71db (diff)
Added by Eric Chavaillaz 4 months ago

[TASK] Do not add target attribute if lightbox is enabled

If config.fileTarget is set, per example to "_blank", the target is
set as fallbak on file link. The target is also added on click enlarge
link but it is not wanted if lightbox is enabled.

This patch ensure that the target attribute is not printed when
lightbox is enabled.

Resolves: #89613
Releases: master, 9.5
Change-Id: Ib40359939a7d8689f43b3418b7b5865794046f1d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62248
Tested-by: TYPO3com <>
Tested-by: Sascha Rademacher <>
Tested-by: Henning Liebe <>
Tested-by: Benni Mack <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Henning Liebe <>
Reviewed-by: Benni Mack <>

Revision 08a55b33 (diff)
Added by Eric Chavaillaz 4 months ago

[TASK] Do not add target attribute if lightbox is enabled

If config.fileTarget is set, per example to "_blank", the target is
set as fallbak on file link. The target is also added on click enlarge
link but it is not wanted if lightbox is enabled.

This patch ensure that the target attribute is not printed when
lightbox is enabled.

Resolves: #89613
Releases: master, 9.5
Change-Id: Ib40359939a7d8689f43b3418b7b5865794046f1d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62944
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62248

#2 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62248

#3 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62944

#4 Updated by Eric Chavaillaz 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF