Bug #89822

Creating a page via drag&drop creates two nodes

Added by Andreas Fernandez about 2 months ago. Updated 28 days ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-12-02
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

If a page is created via drag&drop, two nodes are rendered in the page tree.

However, one node represents the record in the database, the second node is virtual only and allows to change the page title.


Related issues

Related to TYPO3 Core - Bug #89687: Page tree sends unnecessary data Closed 2019-11-14

Associated revisions

Revision 594b19fd (diff)
Added by Andreas Fernandez about 2 months ago

[BUGFIX] Do not apply default node settings when invoking command

The issue #89687 introduced a smaller response for page tree nodes by
moving sane default attributes to JavaScript and overriding with the
actual result.

However, this is also done if a new page is created via drag&drop, the
attribute get in a mixed state and page tree hurts itself in confusion.

The default attributes are now applied only if no DataHandler command is
invoked.

Additionally, some variables in TreeController were wrongly used, which
has been fixed as well.

Resolves: #89822
Related: #89687
Releases: master, 9.5
Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507
Tested-by: Claus Due <>
Tested-by: TYPO3com <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Claus Due <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Tymoteusz Motylewski <>

Revision 03cb0686 (diff)
Added by Andreas Fernandez about 2 months ago

[BUGFIX] Do not apply default node settings when invoking command

The issue #89687 introduced a smaller response for page tree nodes by
moving sane default attributes to JavaScript and overriding with the
actual result.

However, this is also done if a new page is created via drag&drop, the
attribute get in a mixed state and page tree hurts itself in confusion.

The default attributes are now applied only if no DataHandler command is
invoked.

Additionally, some variables in TreeController were wrongly used, which
has been fixed as well.

Resolves: #89822
Related: #89687
Releases: master, 9.5
Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62458
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Oliver Bartsch <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Tymoteusz Motylewski <>

History

#1 Updated by Andreas Fernandez about 2 months ago

  • Related to Bug #89687: Page tree sends unnecessary data added

#2 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507

#3 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507

#4 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507

#5 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62458

#6 Updated by Andreas Fernandez about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 28 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF