Bug #89687

Epic #88474: Page tree performance in 9.5

Page tree sends unnecessary data

Added by Tymoteusz Motylewski 24 days ago. Updated 9 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-11-14
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The page tree sends information about page items as json.
It contains all properties of the item even if they are defaylt values.

In order to save some bandwidth, we should only send non-default values.


Related issues

Related to TYPO3 Core - Bug #88943: Pagetree taking extremely long to load for editors Under Review 2019-08-09
Related to TYPO3 Core - Bug #89822: Creating a page via drag&drop creates two nodes Resolved 2019-12-02

Associated revisions

Revision c57f959a (diff)
Added by Tymoteusz Motylewski 9 days ago

[BUGFIX] Do not send default data for page tree items

In order to lower response size (by 40-50%) of the page tree controller
several page tree item properties are only sent
when they have non-default values.

Resolves: #89687
Releases: master, 9.5
Change-Id: I65ef2b21c71041994ea86d09d1b989b4515e2e42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62329
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>
Tested-by: Benni Mack <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Benni Mack <>

Revision b2458ce1 (diff)
Added by Tymoteusz Motylewski 6 days ago

[BUGFIX] Do not send default data for page tree items

In order to lower response size (by 40-50%) of the page tree controller
several page tree item properties are only sent
when they have non-default values.

Resolves: #89687
Releases: master, 9.5
Change-Id: I65ef2b21c71041994ea86d09d1b989b4515e2e42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62456
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Tymoteusz Motylewski <>

Revision 594b19fd (diff)
Added by Andreas Fernandez 6 days ago

[BUGFIX] Do not apply default node settings when invoking command

The issue #89687 introduced a smaller response for page tree nodes by
moving sane default attributes to JavaScript and overriding with the
actual result.

However, this is also done if a new page is created via drag&drop, the
attribute get in a mixed state and page tree hurts itself in confusion.

The default attributes are now applied only if no DataHandler command is
invoked.

Additionally, some variables in TreeController were wrongly used, which
has been fixed as well.

Resolves: #89822
Related: #89687
Releases: master, 9.5
Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507
Tested-by: Claus Due <>
Tested-by: TYPO3com <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Claus Due <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Tymoteusz Motylewski <>

Revision 03cb0686 (diff)
Added by Andreas Fernandez 2 days ago

[BUGFIX] Do not apply default node settings when invoking command

The issue #89687 introduced a smaller response for page tree nodes by
moving sane default attributes to JavaScript and overriding with the
actual result.

However, this is also done if a new page is created via drag&drop, the
attribute get in a mixed state and page tree hurts itself in confusion.

The default attributes are now applied only if no DataHandler command is
invoked.

Additionally, some variables in TreeController were wrongly used, which
has been fixed as well.

Resolves: #89822
Related: #89687
Releases: master, 9.5
Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62458
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Oliver Bartsch <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review 24 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62329

#2 Updated by Gerrit Code Review 23 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62329

#3 Updated by Tymoteusz Motylewski 23 days ago

  • Related to Bug #88943: Pagetree taking extremely long to load for editors added

#4 Updated by Tymoteusz Motylewski 23 days ago

  • Parent task set to #88474

#5 Updated by Gerrit Code Review 16 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62329

#6 Updated by Gerrit Code Review 9 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62456

#7 Updated by Gerrit Code Review 9 days ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62456

#8 Updated by Tymoteusz Motylewski 9 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Andreas Fernandez 6 days ago

  • Related to Bug #89822: Creating a page via drag&drop creates two nodes added

Also available in: Atom PDF