Bug #89838

Access modul does not set all database fields during update

Added by Jan Delius about 2 months ago. Updated 7 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2019-12-03
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you edit the access rights via the pen button in the Access module, the following fields are only changed in the default language and not in the translated entries:
perms_userid, perms_groupid, perms_user, perms_group, perms_everybody

If you modify the values via icon (permissions) or inline selection field (owner & group) they will be set correctly.

Steps to reproduce:

1. Create a new page
2. Create translation of that page
3. Open the access module and click the edit icon ("Change permissions") for that page
4. Change any field (e.g. "Owner" to none) and save the form
5. The page record for the default language will have the correct values, any translation will not.

If an editor now edits the page in any language (also in the default language) an error occurs that the translations cannot be saved as long as the editor did not already have the required rights before the change in the Access module.
"Attempt to modify record ... without permissions"


Related issues

Related to TYPO3 Core - Bug #88311: Access does not set all necessary rights Resolved 2019-05-09

Associated revisions

Revision dcbb0d73 (diff)
Added by Benni Mack 7 days ago

[BUGFIX] Access module uses DataHandler for updating page

The permission access module allows for AJAX calls to dynamically
updating page permissions on the fly, where DataHandler is used.

When using the form to do a more customizable change,
plain SQL was used previously to update the pages. This circumvented
the change to also update any translated pages (which DataHandler does
by default).

This wasn't a problem until TYPO3 v9.0, where pages_language_overlay
was merged with "pages", where the permissions of translated pages
should reflect the changes of the default language page.

The change updates the PermissionController->updateAction
to call DataHandler for the changes as well.

Resolves: #89838
Resolves: #88311
Releases: master, 9.5
Change-Id: I9e56b279ddcbb43ee7bb11b330c288b12a0e7439
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62930
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Jörg Bösche <>
Tested-by: Daniel Goerz <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Daniel Goerz <>

Revision fbbfcaec (diff)
Added by Benni Mack 7 days ago

[BUGFIX] Access module uses DataHandler for updating page

The permission access module allows for AJAX calls to dynamically
updating page permissions on the fly, where DataHandler is used.

When using the form to do a more customizable change,
plain SQL was used previously to update the pages. This circumvented
the change to also update any translated pages (which DataHandler does
by default).

This wasn't a problem until TYPO3 v9.0, where pages_language_overlay
was merged with "pages", where the permissions of translated pages
should reflect the changes of the default language page.

The change updates the PermissionController->updateAction
to call DataHandler for the changes as well.

Resolves: #89838
Resolves: #88311
Releases: master, 9.5
Change-Id: I9e56b279ddcbb43ee7bb11b330c288b12a0e7439
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62938
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Riccardo De Contardi about 2 months ago

  • Category set to Backend User Interface

#2 Updated by Benni Mack 7 days ago

  • Related to Bug #88311: Access does not set all necessary rights added

#3 Updated by Gerrit Code Review 7 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62930

#4 Updated by Gerrit Code Review 7 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62930

#5 Updated by Gerrit Code Review 7 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62938

#6 Updated by Benni Mack 7 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF