Bug #89842

ResourceStorage::evaluatePermisson set to true unconditionally in FileStorageExtraction/IndexingTask

Added by Alexander Opitz 11 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Start date:
2019-12-03
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Since TYPO3 6.2 the both tasks got implemented to call ResourceStorage::setEvaluatePermissions(false) before and ResourceStorage::setEvaluatePermissions(true) afterwards. This was needed as the cli user may not have access rights while scheduler runs.

If now a task runs in same scheduler call after the FileStorageExtraction/IndexingTask he can't access the storage anymore

Task failed to execute successfully. Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 7, Code: 1430657869, You are not allowed to read folders

To reproduce:

  • In Scheduler add "File Abstraction Layer: Update storage index (scheduler)" and select your fileadmin as path
  • Add another Task, which does FAL handling like
    ResourceFactory::getInstance()
    ->getObjectFromCombinedIdentifier('1:'); // Root path of fileadmin normally
    
  • Select both tasks in Scheduler and press the "Run selected tasks" button

Result:

  • The Update Storage runs, but the second tasks fails with error message

Expected Result:

  • Both tasks run cleanly

Associated revisions

Revision e331227b (diff)
Added by Susanne Moog 10 months ago

[BUGFIX] Reset evaluate permissions to previous value

Resolves: #89842
Releases: master, 9.5
Change-Id: I42ffcc313290867d0410265f4c900225ceb554e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62545
Tested-by: TYPO3com <>
Tested-by: Alexander Opitz <>
Tested-by: Benni Mack <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Alexander Opitz <>
Reviewed-by: Benni Mack <>

Revision 9b748609 (diff)
Added by Susanne Moog 10 months ago

[BUGFIX] Reset evaluate permissions to previous value

Resolves: #89842
Releases: master, 9.5
Change-Id: I42ffcc313290867d0410265f4c900225ceb554e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62671
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62545

#2 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62671

#3 Updated by Susanne Moog 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF