Project

General

Profile

Actions

Bug #89927

closed

Workspace Publishing: marked records not cleared

Added by Andreas Kiessling over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2019-12-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The publishing process in the workspace module seems to not clear the selected items after a first run.
Thus publishing multiple times (without reloading the whole backend) crashes with error messages like this:

Element "tt_content:35" does not exist

How to reproduce:
  • open workspace module
  • select a record
  • use "Choose selection action" -> Publish
  • confirm the modal -> first publish works, module seems to reload and the previously selected is not shown anymore
  • select another record and publish again
  • modal keeps spinning, network request shows an exception like above

Although the first record is not shown anymore in the workspace module, it is included in the second request again. The selection of records is stored in Backend.markedRecordsForMassAction, which seems to be not cleared after any publishing action.
I could reproduce this error in TYPO3 8.7 and 9.5, in 10.2 the backend module seems to be broken and crashed with a different error. But judging from the TypeScript code, the selection seems to be not cleared either https://github.com/TYPO3/TYPO3.CMS/blob/master/Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts

For anyone with the same problem: just reload the workspace-module, e.g. by clicking the page in the pagetree again and run the second publish afterwards.

Actions #1

Updated by Christian Kuhn over 3 years ago

Confirmed.

Reproduce:
  • Create a page in LIVE with two content elements header, 'el 1' and 'el 2'
  • Go to a workspace
  • Change both content elements to 'el 1 changed' and 'el 2 changed'
  • Go to workspace module for that page
  • Check 'el 1 changed' > Choose selection Action -> Publish -> Wizard -> next
    > This element is published to live and vanishes from the list
  • Do NOT reload the workspace module!
  • Check 'el 2 changed' (the one row left) -> Choose selection Action -> Publish -> Wizard -> next -> boom, 500 from server, wizard does not disappear

Reason: the payload from publish request 2 still contains the element form request 1.

Actions #2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65185

Actions #3

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65185

Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65170

Actions #5

Updated by Christian Kuhn over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF