Task #90053

Refactor route enhancer tests

Added by Oliver Hader about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-01-04
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #90153: Extend route enhancer test framework Resolved 2020-01-20

Associated revisions

Revision f8eac638 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Refactor route enhancer tests

  • replaces nested array logic with domain objects
  • introduces perputation logic (instead of foreach/foreach/foreach/...)
  • introduced common variables container compiled when executing tests
    (allows to declare arbitrary behaviour without hardcoding values)
  • applies more specific page type decorators in request tests

Resolves: #90053
Releases: master, 9.5
Change-Id: Id145de4aafc419ab70cd60fb8a439144307a0cec
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Felix P. <>
Tested-by: Tobi Kretschmann <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Felix P. <>
Reviewed-by: Tobi Kretschmann <>

Revision 09fd6661 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Refactor route enhancer tests

  • replaces nested array logic with domain objects
  • introduces perputation logic (instead of foreach/foreach/foreach/...)
  • introduced common variables container compiled when executing tests
    (allows to declare arbitrary behaviour without hardcoding values)
  • applies more specific page type decorators in request tests

Resolves: #90053
Releases: master, 9.5
Change-Id: Id145de4aafc419ab70cd60fb8a439144307a0cec
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62876
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#2 Updated by Gerrit Code Review about 2 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#3 Updated by Gerrit Code Review about 2 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#4 Updated by Gerrit Code Review about 2 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#5 Updated by Gerrit Code Review about 2 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#6 Updated by Gerrit Code Review about 1 month ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#7 Updated by Gerrit Code Review about 1 month ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#8 Updated by Gerrit Code Review about 1 month ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815

#9 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Gerrit Code Review about 1 month ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62876

#11 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved

#12 Updated by Oliver Hader about 1 month ago

  • Related to Task #90153: Extend route enhancer test framework added

Also available in: Atom PDF