Task #90153

Extend route enhancer test framework

Added by Oliver Hader about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-01-20
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • introduces ApplicableConjunction and corresponding handling
  • introduces defined state check on variables (not null)
  • adds possibility to merge with existing enhancer declaration
  • adjusts VariableItem to support scalar values as well
  • adds human readable output for empty string and null values

Related issues

Related to TYPO3 Core - Task #90053: Refactor route enhancer tests Resolved 2020-01-04

Associated revisions

Revision cc26fdc0 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Extend route enhancer test framework

+ introduces ApplicableConjunction and corresponding handling
+ introduces defined state check on variables (not-null variables)
+ adds possibility to merge with existing enhancer declaration
+ adjusts VariableItem to support scalar values as well
+ adds human readable output for empty string and null values

Resolves: #90153
Releases: master, 9.5
Change-Id: I248238daced063cf91de93f7527477d13064dca2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62997
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision 748098ec (diff)
Added by Oliver Hader about 1 month ago

[TASK] Extend route enhancer test framework

+ introduces ApplicableConjunction and corresponding handling
+ introduces defined state check on variables (not-null variables)
+ adds possibility to merge with existing enhancer declaration
+ adjusts VariableItem to support scalar values as well
+ adds human readable output for empty string and null values

Resolves: #90153
Releases: master, 9.5
Change-Id: I248238daced063cf91de93f7527477d13064dca2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62998
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision 35386e54 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Extend route enhancer test framework

  • introduce `routeParameter` variable (default `{value}`)
  • introduce ExceptionExpectation applicable in test cases
  • adjust TestSet::getSingleApplicable($type) to consider
    ApplicableConjunction as well
  • adjust configuration/declaration merges

Resolves: #90153
Releases: master, 9.5
Change-Id: Ic0e84ac91bb3a9f7a1d8b004052b8d93867a39e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63005
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision dd1a2c01 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Extend route enhancer test framework

  • introduce `routeParameter` variable (default `{value}`)
  • introduce ExceptionExpectation applicable in test cases
  • adjust TestSet::getSingleApplicable($type) to consider
    ApplicableConjunction as well
  • adjust configuration/declaration merges

Resolves: #90153
Releases: master, 9.5
Change-Id: Ic0e84ac91bb3a9f7a1d8b004052b8d93867a39e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63006
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62997

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62998

#3 Updated by Oliver Hader about 1 month ago

  • Related to Task #90053: Refactor route enhancer tests added

#4 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62998

#5 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62997

#6 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review about 1 month ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63005

#8 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63006

#9 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63005

#10 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63006

#11 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF