Task #90105

Allow full row to be passed into isInWebMount()

Added by Markus Klein 12 days ago. Updated 11 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Performance
Target version:
-
Start date:
2020-01-13
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In couple of places the BackendUserAuthentication::isInWebMount function is called.
In some cases the actual page row is already in memory, so it can be re-used inside the function.

Extending the function signature to allow either the page uid or the page record to be passed, speeds up the whole system.
This is noticable in the page tree for instance.


Related issues

Related to TYPO3 Core - Epic #88474: Page tree performance in 9.5 New 2018-11-16

Associated revisions

Revision a4809174 (diff)
Added by Markus Klein 11 days ago

[TASK] Allow record or uid for isInWebMount

Extend the function signature of BackendUserAuthentication::isInWebMount
to allow the uid of a page or the full page record.
This saves another database lookup for the page.

Resolves: #90105
Releases: master, 9.5
Change-Id: Id246967b7a8237dbe8939126acf21fede6dda756
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868
Reviewed-by: Susanne Moog <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Benni Mack <>
Tested-by: Susanne Moog <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>

Revision 7e984028 (diff)
Added by Markus Klein 10 days ago

[TASK] Allow record or uid for isInWebMount

Extend the function signature of BackendUserAuthentication::isInWebMount
to allow the uid of a page or the full page record.
This saves another database lookup for the page.

Resolves: #90105
Releases: master, 9.5
Change-Id: Id246967b7a8237dbe8939126acf21fede6dda756
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62904
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 12 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#2 Updated by Markus Klein 12 days ago

  • Related to Epic #88474: Page tree performance in 9.5 added

#3 Updated by Gerrit Code Review 12 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#4 Updated by Gerrit Code Review 11 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#5 Updated by Gerrit Code Review 11 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#6 Updated by Gerrit Code Review 11 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62904

#7 Updated by Gerrit Code Review 11 days ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62904

#8 Updated by Markus Klein 11 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF