Task #90105

Allow full row to be passed into isInWebMount()

Added by Markus Klein 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Performance
Target version:
-
Start date:
2020-01-13
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In couple of places the BackendUserAuthentication::isInWebMount function is called.
In some cases the actual page row is already in memory, so it can be re-used inside the function.

Extending the function signature to allow either the page uid or the page record to be passed, speeds up the whole system.
This is noticable in the page tree for instance.


Related issues

Related to TYPO3 Core - Epic #88474: Page tree performance in 9.5 New 2018-11-16
Related to TYPO3 Core - Task #91037: Tune permission check in page tree Closed 2020-04-14

Associated revisions

Revision a4809174 (diff)
Added by Markus Klein 9 months ago

[TASK] Allow record or uid for isInWebMount

Extend the function signature of BackendUserAuthentication::isInWebMount
to allow the uid of a page or the full page record.
This saves another database lookup for the page.

Resolves: #90105
Releases: master, 9.5
Change-Id: Id246967b7a8237dbe8939126acf21fede6dda756
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868
Reviewed-by: Susanne Moog <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Benni Mack <>
Tested-by: Susanne Moog <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>

Revision 7e984028 (diff)
Added by Markus Klein 9 months ago

[TASK] Allow record or uid for isInWebMount

Extend the function signature of BackendUserAuthentication::isInWebMount
to allow the uid of a page or the full page record.
This saves another database lookup for the page.

Resolves: #90105
Releases: master, 9.5
Change-Id: Id246967b7a8237dbe8939126acf21fede6dda756
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62904
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

Revision fb2740a2 (diff)
Added by Tymoteusz Motylewski 6 months ago

[TASK] Tune permission checks in TreeController

Do not calculate permissions for every page, as we're limiting the pages
through SQL query constraints.

Fetch sys_language_uid and l10n_parent from db as they are required for
isInWebMount to prevent it from fetching row from db again.

Pass full row to isInWebMount in calcPerms instead of just uid.
isInWebMount has logic to handle translated records.

Resolves: #91037
Related: #90105
Releases: 9.5, master
Change-Id: I56dbaf3daa15aa8b6f0fc5e09b212aa34203a0b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64175
Tested-by: TYPO3com <>
Tested-by: Markus Klein <>
Tested-by: Benni Mack <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Reviewed-by: Tymoteusz Motylewski <>

Revision 0e66ed43 (diff)
Added by Tymoteusz Motylewski 6 months ago

[TASK] Tune permission checks in TreeController

Do not calculate permissions for every page, as we're limiting the pages
through SQL query constraints.

Fetch sys_language_uid and l10n_parent from db as they are required for
isInWebMount to prevent it from fetching row from db again.

Pass full row to isInWebMount in calcPerms instead of just uid.
isInWebMount has logic to handle translated records.

Resolves: #91037
Related: #90105
Releases: 9.5, master
Change-Id: I56dbaf3daa15aa8b6f0fc5e09b212aa34203a0b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64141
Tested-by: TYPO3com <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#2 Updated by Markus Klein 9 months ago

  • Related to Epic #88474: Page tree performance in 9.5 added

#3 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#4 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#5 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62868

#6 Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62904

#7 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62904

#8 Updated by Markus Klein 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

#10 Updated by Tymoteusz Motylewski 6 months ago

  • Related to Task #91037: Tune permission check in page tree added

Also available in: Atom PDF