Task #90207: Add a couple if code cleanups for phpstan - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #90207

closed

Add a couple if code cleanups for phpstan

Added by Alexander Schnitzler almost 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Alexander Schnitzler

Category:

Code Cleanup

Target version:

Start date:

2020-01-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

- Add phpdoc for variables to let phpstan know their type
- Do not use ::class syntax for PHP 7.4 classes (yet)
- Add missing class properties
- Do not unset non-existing variables

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039

Actions

Copy link