Task #90218

Dissolve PersistenceDelegate for persisted mappers

Added by Oliver Hader 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-01-27
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The intention of PersistenceDelegate was to provide a generic API to
resolve or generate route components. However the implementation did
not provide any additional behavior. It just was used as structural
pattern which did not provide any further advantages.

That's the reason why PersistenceDelegate gets dissolved and its
database connection invocation is moved to its corresponding callers
PersistedAliasMapper and PersistedPatternMapper.


Related issues

Related to TYPO3 Core - Bug #89153: Wrong Extbase record is shown for slug Closed 2019-09-11
Related to TYPO3 Core - Bug #90269: Use correct method name in PersistedPatternMapper legacy trait Closed 2020-01-31
Related to TYPO3 Core - Bug #92368: PersistedAliasMapper: 404 error when linking to a non-translated news record New 2020-09-22

Associated revisions

Revision bd69d119 (diff)
Added by Oliver Hader 9 months ago

[TASK] Dissolve PersistenceDelegate for persisted mappers

The intention of PersistenceDelegate was to provide a generic API to
resolve or generate route components. However the implementation did
not provide any additional behavior. It just was used as structural
pattern which did not provide any further advantages.

That's the reason why PersistenceDelegate gets dissolved and its
database connection invocation is moved to its corresponding callers
PersistedAliasMapper and PersistedPatternMapper.

For backward-compatibility reasons previous (protected) implementation
is still kept in legacy layer for those two route aspects.

Resolves: #90218
Releases: master, 9.5
Change-Id: I49eb58372c139c9b8274593efa2892a43eb81508
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63049
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Reviewed-by: Johannes Schlier
Reviewed-by: Susanne Moog <>

Revision 48d7af70 (diff)
Added by Oliver Hader 9 months ago

[TASK] Dissolve PersistenceDelegate for persisted mappers

The intention of PersistenceDelegate was to provide a generic API to
resolve or generate route components. However the implementation did
not provide any additional behavior. It just was used as structural
pattern which did not provide any further advantages.

That's the reason why PersistenceDelegate gets dissolved and its
database connection invocation is moved to its corresponding callers
PersistedAliasMapper and PersistedPatternMapper.

For backward-compatibility reasons previous (protected) implementation
is still kept in legacy layer for those two route aspects.

Resolves: #90218
Releases: master, 9.5
Change-Id: I49eb58372c139c9b8274593efa2892a43eb81508
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63048
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Oliver Hader 9 months ago

  • Related to Bug #89153: Wrong Extbase record is shown for slug added

#2 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63048

#3 Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63049

#4 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63049

#5 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63048

#6 Updated by Oliver Hader 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Oliver Hader 9 months ago

  • Related to Bug #90269: Use correct method name in PersistedPatternMapper legacy trait added

#8 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

#9 Updated by Georg Ringer about 1 month ago

  • Related to Bug #92368: PersistedAliasMapper: 404 error when linking to a non-translated news record added

Also available in: Atom PDF