Bug #90232

Database result is not used to built result array for linkvalidator

Added by Daniel Siepmann 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2020-01-28
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Within () the following code is uses:

        while ($row = $statement->fetch()) {
            $result[$row['link_type']] = $result['amount'];
        }

This results in an empty list, null assignment.

Instead the following should be used:

        while ($row = $statement->fetch()) {
            $result[$row['link_type']] = $row['amount'];
        }

linkvalidator.png View (30.2 KB) Sybille Peters, 2020-01-28 15:48

Associated revisions

Revision c445ea2c (diff)
Added by Daniel Siepmann 4 months ago

[BUGFIX] Use database result to built broken link result

Resolves: #90232
Releases: master
Change-Id: If9b030c8f984914d41482d0ab5fd7f94e1385b58
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63060
Reviewed-by: Mathias Brodala <>
Reviewed-by: Sybille Peters <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Sybille Peters <>
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63060

#2 Updated by Sybille Peters 4 months ago

This results in number of broken links to be shown as always 0.

The proposed patch fixes this problem!

#3 Updated by Daniel Siepmann 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF