Project

General

Profile

Actions
Copy link

Bug #90232

closed

Database result is not used to built result array for linkvalidator

Added by Daniel Siepmann almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Daniel Siepmann
Category:
Linkvalidator
Target version:
-
Start date:
2020-01-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Within () the following code is uses:

        while ($row = $statement->fetch()) {
            $result[$row['link_type']] = $result['amount'];
        }

This results in an empty list, null assignment.

Instead the following should be used:

        while ($row = $statement->fetch()) {
            $result[$row['link_type']] = $row['amount'];
        }

Files

linkvalidator.png (30.2 KB) linkvalidator.png Sybille Peters, 2020-01-28 15:48
Actions
Copy link
 #1

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63060

Actions
Copy link
 #2

Updated by Sybille Peters almost 5 years ago

This results in number of broken links to be shown as always 0.

The proposed patch fixes this problem!

Actions
Copy link
 #3

Updated by Daniel Siepmann almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF