Bug #90238

In finishers fieldExplanationText does not work on all inspectors

Added by Stig Nørgaard Færch 27 days ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2020-01-29
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

fieldExplanationText works fine with Inspector-TextareaEditor and Inspector-TextEditor, but does not seem to work at all with Inspector-CheckboxEditor.
There might be more inspectors where it doesn't work.
Try this, which will add a couple of fields to both email finishers:

TYPO3:
  CMS:
    Form:
      mixins:
        formElementMixins:
          formEmailFinisherMixin:
            editors:
              2000:
                identifier: 'includeFormValues'
                templateName: 'Inspector-CheckboxEditor'
                label: 'Include form data in mail'
                propertyPath: 'options.includeFormValues'
                fieldExplanationText: 'The explanation text is not shown'
              2100:
                identifier: 'customText'
                templateName: 'Inspector-TextareaEditor'
                label: 'Alternative text for mail'
                propertyPath: 'options.customText'
                fieldExplanationText: 'This explanation does show'

Associated revisions

Revision ad995ee2 (diff)
Added by Andreas Fernandez 15 days ago

[BUGFIX] Check correctly for existing click event

With #90238 the JavaScript function `goToalt_doc` is registered as a
Fluid variable. However, the check for an existing event in the template
broke as the variable now always has a value.

To fix the situation, a new boolean variable `hasClickEvent` is
introduced.

Resolves: #90344
Related: #90238
Releases: master, 9.5
Change-Id: I7d86d300be923db82a0f79c3dd479a708230d92d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63185
Reviewed-by: Claus Due <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Richard Haeser <>
Tested-by: Daniel Goerz <>
Tested-by: Richard Haeser <>

Also available in: Atom PDF