Task #90516

RootlineUtility::purgeCaches contains note that function is only intended for unit tests but it is being used

Added by Sybille Peters about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Documentation
Target version:
-
Start date:
2020-02-24
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

/**
 * Purges all rootline caches.
 *
 * Note: This function is intended to be used in unit tests only.
 */
public static function purgeCaches()
{
    self::$localCache = [];
    self::$pageRecordCache = [];
}

typo3/sysext/core/Classes/DataHandling/SlugHelper.php:        RootlineUtility::purgeCaches();
typo3/sysext/core/Classes/Routing/SiteMatcher.php:        RootlineUtility::purgeCaches();

So, maybe remove the note or check if it's ok to use the function?

Associated revisions

Revision e6f1bec5 (diff)
Added by Georg Ringer about 1 month ago

[TASK] Define RootlineUtility::purgeCaches as internal

Remove the outdated note about using in unit tests only and set the
method to internal as it used by the core but shouldn't be any public
API.

Resolves: #90516
Releases: master. 9.5
Change-Id: I422e3982844b06d34fbb66ab77b26ace48fd537b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63442
Tested-by: TYPO3com <>
Tested-by: Christian Eßl <>
Tested-by: Oliver Klee <>
Tested-by: Benni Mack <>
Reviewed-by: Christian Eßl <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Benni Mack <>

Revision 87751a46 (diff)
Added by Georg Ringer about 1 month ago

[TASK] Define RootlineUtility::purgeCaches as internal

Remove the outdated note about using in unit tests only and set the
method to internal as it used by the core but shouldn't be any public
API.

Resolves: #90516
Releases: master, 9.5
Change-Id: I422e3982844b06d34fbb66ab77b26ace48fd537b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63453
Tested-by: Georg Ringer <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Georg Ringer about 1 month ago

  • Category changed from Caching to Documentation

#2 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63442

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63453

#4 Updated by Georg Ringer about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF