Bug #90776

Cannot use tab category name with spaces in extension configuration

Added by Florian Rival 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Extension Manager
Target version:
Start date:
2020-03-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

Regression appears in Typo3 V10 in "Settigs > Extension Configuration".

It's not possible to have a tab category name with space like "Site configuration", ext_conf_template.txt :

# cat=Site configuration/160/20_LangTitle; type=string; label=Language title: The language title (ex : English)
langTitle = English

The regression appears in file sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html

In V9 :

<a class="text-capitalize" href="#{i:format.noSpace(value:'category-{extensionKey}-{categoryName}')}" aria-controls="category-{extensionKey}-{categoryName}" role="tab" data-toggle="tab">{categoryName}</a>

In V10 :

<a class="text-capitalize" href="#category-{extensionKey}-{categoryName}" aria-controls="category-{extensionKey}-{categoryName}" role="tab" data-toggle="tab">{categoryName}</a>

The ViewHelper "{i:format.noSpace()}" was removed so href look like this :

#category-my_ext-Site configuration

instead of :

#category-my_ext-Siteconfiguration

See commit : https://github.com/TYPO3/TYPO3.CMS/commit/b93798c345204a59f165e528eb49f050c0225a8a#diff-723d3ecba84824d6b4ebe6c299364cb8


Related issues

Related to TYPO3 Core - Task #89956: Install tool extension configuration template contains redundant codeClosed2019-12-16

Actions
#1

Updated by Georg Ringer 8 months ago

  • Status changed from New to Accepted
  • Assignee set to Georg Ringer

I always suggest to use translated labels but will of course fit it.

#2

Updated by Georg Ringer 8 months ago

  • Related to Task #89956: Install tool extension configuration template contains redundant code added
#3

Updated by Gerrit Code Review 8 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63764

#4

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63764

#5

Updated by Georg Ringer 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF