Bug #90777

Trying to edit an existing file mount in BE group form results in error

Added by Sybille Peters 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2020-03-18
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The question is: How to edit (existing) file mount in be groups form in BE?
I don't know how to do it. If there is a way to do it, perhaps there is a way to make this more intuitive.

Reproduce

  1. Open form for editing a group
  2. There are some existing file mounts in the list of "Available items"
  3. There is (AFAIK) no way to select one without moving it to the list "Selected items", but selecting it and then removing it again supposedly make it selected in the list "Available Items"
  4. click the pencil "Edit filemount"

Actual outcome

Even if an item is selected, clicking on the edit pencil yields:

"Please select one or more items in the list before you can edit."

Expected outcome

The edit pencil "Edit filemount" should edit the selected item

filemount.png View (23.9 KB) Sybille Peters, 2020-03-18 12:40

step1.png View (85.8 KB) Susanne Moog, 2020-03-19 11:23

Associated revisions

Revision 3503dfae (diff)
Added by Susanne Moog 2 months ago

[TASK] Render edit popup of SelectMultipleSideBySide at intuitive place

When using the edit popup of SelectMultipleSideBySide editing is related
to the items that are active and selected in the element. The old
placement of the edit pencil however suggested that it should be
possible to edit all (even inactive items, unrelated to the current
record) elements. Whenever an editPopup is configured to be shown in
a SelectMultipleSideBySide element, the edit pencil is now placed
directly next to the active select items.

Resolves: #90777
Releases: master
Change-Id: Iac8df9dafca455adb4b18d5bca882fa2ab3bd0cc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63792
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Susanne Moog 2 months ago

  • Status changed from New to Accepted

I think the expected behaviour should be different, however I agree that we have a UI problem here:

It's totally fine IMHO that the edit pencil only allows editing of active items in this context, as it doesn't make much sense to go through the length of opening this group record to edit an unrelated group - and in fact is the source of the problem here, as the data is taken from the active records field with that value. --> Selecting it by first selecting than unselecting is also kind of awkward.

However the placement of the pencil on the right of the field does suggest the editing of all records and should probably be moved.

#2 Updated by Gerrit Code Review 2 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63792

#3 Updated by Susanne Moog 2 months ago

#4 Updated by Sybille Peters 2 months ago

Yes, I agree. Removing the pencil would be sufficient. There are other places to edit the filemounts (e.g. on page 0).

#5 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63792

#6 Updated by Susanne Moog 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF