Task #90880

Filter pages user has access to on query time

Added by Tymoteusz Motylewski 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2020-03-30
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In order to reduce the amount of data fetched, the PageTree loaded
for editors will only fetch pages that the editor actually sees, reducing
the actual amount of pages to fetch.

If a pagetree has 80.000 pages, but the editor can only see 50, the
tree only loads these 50 pages.


Related issues

Related to TYPO3 Core - Bug #91221: Pagetree does not show with an editor account and a mounted page in a system folder in Typo3 9.5.16 Under Review 2020-04-28
Precedes TYPO3 Core - Task #91348: Revert PageReadPermission check for TreeController Closed 2020-03-31 2020-03-31

Associated revisions

Revision 637b36c7 (diff)
Added by Benni Mack about 2 months ago

[BUGFIX] Include Page Read Permissions to PageTreeController

In order to reduce the amount of data fetched, the PageTree loaded
for editors will only fetch pages that the editor actually sees, reducing
the actual amount of pages to fetch.

If a pagetree has 80.000 pages, but the editor can only see 50, the
tree only loads these 50 pages.

Resolves: #90880
Releases: master, 9.5
Change-Id: I57985484ace07fbfb919573351c210b291697ae3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570
Tested-by: Oliver Hader <>
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Oliver Hader <>
Reviewed-by: Susanne Moog <>

Revision 685e9a23 (diff)
Added by Benni Mack about 2 months ago

[BUGFIX] Include Page Read Permissions to PageTreeController

In order to reduce the amount of data fetched, the PageTree loaded
for editors will only fetch pages that the editor actually sees, reducing
the actual amount of pages to fetch.

If a pagetree has 80.000 pages, but the editor can only see 50, the
tree only loads these 50 pages.

Resolves: #90880
Releases: master, 9.5
Change-Id: I57985484ace07fbfb919573351c210b291697ae3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63983
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Susanne Moog <>

Revision 49d8b1cc (diff)
Added by Benni Mack 18 days ago

[BUGFIX] Revert PageReadPermission check for TreeController

In order to allow non-admins to fetch nodes which have no "pid=0"
the change to only fetch pages with access, the change to
check on a DB query basis is reverted.

Additionally a functional tests is extended to cover the problematic case.

Resolves: #91348
Related: #90880
Releases: master, 9.5
Change-Id: I3f737c92c8164c572f7e58335d92a82a4a5aa4dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64431
Tested-by: Tymoteusz Motylewski <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Oliver Hader <>
Reviewed-by: Benni Mack <>

Revision d9616d69 (diff)
Added by Benni Mack 18 days ago

[BUGFIX] Revert PageReadPermission check for TreeController

In order to allow non-admins to fetch nodes which have no "pid=0"
the change to only fetch pages with access, the change to
check on a DB query basis is reverted.

Additionally a functional tests is extended to cover the problematic case.

Resolves: #91348
Related: #90880
Releases: master, 9.5
Change-Id: I3f737c92c8164c572f7e58335d92a82a4a5aa4dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64369
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570

#2 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570

#3 Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570

#4 Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570

#5 Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570

#6 Updated by Gerrit Code Review about 2 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570

#7 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63983

#8 Updated by Benni Mack about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

#10 Updated by Tymoteusz Motylewski 22 days ago

  • Related to Bug #91221: Pagetree does not show with an editor account and a mounted page in a system folder in Typo3 9.5.16 added

#11 Updated by Benni Mack 22 days ago

  • Precedes Task #91348: Revert PageReadPermission check for TreeController added

Also available in: Atom PDF