Bug #90969

Administration log broken due to unsupported type annotation

Added by Daniel Siepmann 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2020-03-31
Due date:
2020-03-31
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

https://github.com/TYPO3/TYPO3.CMS/commit/555e116f405295edf63394b647d680a9d46de0f7 adjusted the type annotation for two properties in the model.
These are not supported by extbase and result in the following error:

(1/1) #1579965021 TYPO3\CMS\Extbase\Persistence\Generic\Mapper\Exception\UnknownPropertyTypeException
The type of property TYPO3\CMS\Belog\Domain\Model\LogEntry::tableName could not be identified, therefore the desired value (0) cannot be mapped onto it. The type of a class property is usually defined via php doc blocks. Make sure the property has a valid @var tag set which defines the type.


Related issues

Follows TYPO3 Core - Task #90893: Enable phpstan DefaultValueTypesAssignedToPropertiesRuleClosed2020-03-30

Actions
#1

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094

#2

Updated by Daniel Siepmann 8 months ago

  • Status changed from Under Review to New

The real solution would be proper support by Extbase. But for now it might be enough to revert the changes of phpstan.

#3

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094

#4

Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094

#5

Updated by Gerrit Code Review 8 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094

#6

Updated by Alexander Schnitzler 8 months ago

  • Is Regression set to Yes
#7

Updated by Alexander Schnitzler 8 months ago

  • Due date set to 2020-03-31
  • Start date changed from 2020-04-07 to 2020-03-31
  • Follows Task #90893: Enable phpstan DefaultValueTypesAssignedToPropertiesRule added
#8

Updated by Gerrit Code Review 8 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094

#9

Updated by Daniel Siepmann 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF