Bug #91027

ExtensionScanner TypeError in extensionScannerMarkFullyScannedRestFiles due to incorrect parsing of Index.rst files

Added by Benjamin Franzke 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2020-04-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Index.rst files do not contain issue numbers and thefore cause
typeerrors when running the extension scanner:

at TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile
->getListEntry('[…]/typo3/sysext/core/Documentation/Changelog/7.0/Index.rst')

(1/1) TypeError
Return value of TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::parseIssueId()
must be of the type string, null returned

in […]/typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php line 355
return GeneralUtility::trimExplode('-', $filename)[1];

at TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile->parseIssueId('Index')
in […]/typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php line 156
$issueId = $this->parseIssueId($entry['filename']);

at TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile
->getListEntry('[…]/typo3/sysext/core/Documentation/Changelog/7.0/Index.rst')

Bildschirmfoto von 2020-04-14 13-49-30.png View (114 KB) Benjamin Franzke, 2020-04-14 14:53


Related issues

Related to TYPO3 Core - Task #90923: Install Tool: Upgrade Doc: add link to rendered rST version on docs.typo3.org Closed 2020-04-01

Associated revisions

Revision a8155cbc (diff)
Added by Benjamin Franzke 3 months ago

[BUGFIX] Fix extension scanner Index.rst filename parsing

Rst files may not contain issue numbers. The extension scanner
iterates all .rst files (including Index.rst) which cases a type
error for typo3/sysext/core/Documentation/Changelog/7.0/Index.rst

(1/1) TypeError
Return value of
TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::parseIssueId()
must be of the type string, null returned

Releases: master, 9.5
Resolves: #91027
Related: #90923
Change-Id: I000675700f9da17f063ccbc52d6ce0beabebf247
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64161
Tested-by: Josef Glatz <>
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Josef Glatz <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Georg Ringer <>

Revision 32e5af77 (diff)
Added by Benjamin Franzke 2 months ago

[BUGFIX] Fix extension scanner Index.rst filename parsing

Rst files may not contain issue numbers. The extension scanner
iterates all .rst files (including Index.rst) which cases a type
error for typo3/sysext/core/Documentation/Changelog/7.0/Index.rst

(1/1) TypeError
Return value of
TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::parseIssueId()
must be of the type string, null returned

Releases: master, 9.5
Resolves: #91027
Related: #90923
Change-Id: I000675700f9da17f063ccbc52d6ce0beabebf247
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64284
Reviewed-by: Josef Glatz <>
Reviewed-by: Benjamin Franzke <>
Tested-by: TYPO3com <>
Tested-by: Josef Glatz <>
Tested-by: Benjamin Franzke <>

History

#1 Updated by Benjamin Franzke 3 months ago

  • Related to Task #90923: Install Tool: Upgrade Doc: add link to rendered rST version on docs.typo3.org added

#2 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64161

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64161

#4 Updated by Benjamin Franzke 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF