Bug #91028

Startup module option: First module in menu not working anymore

Added by Richard Haeser 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2020-04-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The option "First module in menu" as the startup module in user settings is not working anymore. When choosing this option, you just got forwarded to the About modules module.

Associated revisions

Revision 7e2a5da7 (diff)
Added by Andreas Fernandez 3 months ago

[BUGFIX] Load the correct "first module"

The start up option "First module in menu" is a misleading in some ways.
The select box e.g. has "dashboard" as first selectable option, but in
such cases the "help_AboutAbout" module is loaded instead, for example.
This is due the fact the first module is determined via querying the DOM
for the first element matching the selector
`.t3js-modulemenu-action[data-link]`.

The behavior is now changed to load the first module as listed in the
previously mentioned select box.

Resolves: #91028
Releases: master
Change-Id: I669a9b146f76f2513c51ff5f48128a1ea8b0c0a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64164
Tested-by: Richard Haeser <>
Tested-by: Georg Ringer <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Andreas Fernandez 3 months ago

  • Status changed from New to Accepted

#2 Updated by Andreas Fernandez 3 months ago

Technically this is correct. If no module is selected, the first module is determined via JavaScript by getting the first module matching the selector .t3js-modulemenu-action[data-link]. I agree this is not what's expected, let's check how to fix this in an appropriate way.

#3 Updated by Andreas Fernandez 3 months ago

  • Status changed from Accepted to In Progress

#4 Updated by Gerrit Code Review 3 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64164

#5 Updated by Andreas Fernandez 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF