Project

General

Profile

Actions

Bug #91219

closed

AssetCollector (or Renderer) does not consider [FE][versionNumberInFilename]

Added by Julian Mair about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2020-04-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The new AssetCollector (or Renderer) does not consider the settings from [FE][versionNumberInFilename].

Maybe because it does not using the following lines, like PageRenderer::processJsFile() does:

// [...]
$filename = GeneralUtility::createVersionNumberedFilename($filename);
// [...]

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #91889: AssetRenderer does not respect FE.versionNumberInFilenameClosed2020-07-29

Actions
Actions #1

Updated by Jonas Eberle about 4 years ago

  • Assignee set to Jonas Eberle
Actions #2

Updated by Julian Mair almost 4 years ago

FYI, I tried a bit and this fix worked:

// [...]
private function getAbsoluteWebPath(string $file): string
{
    if (strpos($file, '://') !== false || strpos($file, '//') === 0) {
        return $file;
    }
    return GeneralUtility::createVersionNumberedFilename(PathUtility::getAbsoluteWebPath(GeneralUtility::getFileAbsFileName($file)));
}

Would this be an adequate solution?

Actions #3

Updated by Georg Ringer over 3 years ago

  • Related to Bug #91889: AssetRenderer does not respect FE.versionNumberInFilename added
Actions #4

Updated by Georg Ringer over 3 years ago

  • Status changed from New to Closed

solved with #91889

Actions

Also available in: Atom PDF