Bug #91889

AssetRenderer does not respect FE.versionNumberInFilename

Added by Torben Hansen 16 days ago. Updated 3 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2020-07-29
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The AssetRenderer for the new AssetCollector in TYPO3 10.4 does not respect the $GLOBALS['TYPO3_CONF_VARS']['FE']['versionNumberInFilename'] setting.

This is a problem, when rendered assets (e.g. JavaScript files) are rendered and cached on the client. When the content of the asset changes server side, the client will not reload the updated asset, since the filename is the same.

We should use GeneralUtility::createVersionNumberedFilename in AssetRenderer::getAbsoluteWebPath() so versioned file names are created.

Associated revisions

Revision 20e05435 (diff)
Added by Georg Ringer 3 days ago

[BUGFIX] Use GeneralUtility::createVersionNumberedFilename in
AssetRenderer

A call to `GeneralUtility::createVersionNumberedFilename` is required to
avoid using outdated files from browser cache.

Resolves: #91889
Releases: master, 10.4
Change-Id: I0963e4e8f447eff111314a8165038fd55c422edc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65238
Tested-by: TYPO3com <>
Tested-by: Torben Hansen <>
Tested-by: Benni Mack <>
Reviewed-by: Torben Hansen <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Benni Mack <>

Revision 90866762 (diff)
Added by Georg Ringer 3 days ago

[BUGFIX] Use GeneralUtility::createVersionNumberedFilename in
AssetRenderer

A call to `GeneralUtility::createVersionNumberedFilename` is required to
avoid using outdated files from browser cache.

Resolves: #91889
Releases: master, 10.4
Change-Id: I0963e4e8f447eff111314a8165038fd55c422edc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65255
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 4 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65238

#2 Updated by Gerrit Code Review 3 days ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65255

#3 Updated by Georg Ringer 3 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF