Bug #91307

Image conversion not possible on older systems

Added by Christian Hernmarck over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Image Generation / GIFBUILDER
Target version:
-
Start date:
2020-05-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
graphicsmagick convert -auto-orient wheezy
Complexity:
Is Regression:
Sprint Focus:

Description

Because of Feature/Bug #69274 all "gm convert" commands fail because my gm does not know "-auto-orient" and doesn't do anything (-> no image resize etc is done - neither backend nor frontend).

"-auto-orient" is not present in graphicsmagick delivered with debian wheezy.

/usr/bin/gm convert: Unrecognized operator (-auto-orient).

Since there won't be many wheezys around I assume I have to patch all sources beginning with v9 - nevertheless I think it's good to open the ticket so next time a new parameter is used: a version check of gm/im is done before...

My patch look like this:

diff -u -r 9511/typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php typo3_src-9.5.11/typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php
--- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php    2019-10-30 21:46:49.000000000 +0100
+++ typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php    2020-01-23 10:48:32.163352508 +0100
@@ -206,7 +206,8 @@
      *
      * @var string
      */
-    public $scalecmd = '-auto-orient -geometry';
+#    public $scalecmd = '-auto-orient -geometry';
+    public $scalecmd = '-geometry';

     /**
      * Used by v5_blur() to simulate 10 continuous steps of blurring
diff -u -r 9511/typo3/sysext/core/Classes/Utility/CommandUtility.php typo3_src-9.5.11/typo3/sysext/core/Classes/Utility/CommandUtility.php
--- typo3/sysext/core/Classes/Utility/CommandUtility.php        2019-10-30 21:46:49.000000000 +0100
+++ typo3/sysext/core/Classes/Utility/CommandUtility.php        2020-01-23 10:47:23.783107250 +0100
@@ -130,9 +130,9 @@
             }
         }
         // Add -auto-orient on convert so IM/GM respects the image orient
-        if ($parameters && $command === 'convert') {
-            $parameters = '-auto-orient ' . $parameters;
-        }
+#        if ($parameters && $command === 'convert') {
+#            $parameters = '-auto-orient ' . $parameters;
+#        }
         // set interlace parameter for convert command
         if ($command !== 'identify' && $gfxConf['processor_interlace']) {
             $parameters = '-interlace ' . $gfxConf['processor_interlace'] . ' ' . $parameters;

#1

Updated by Andreas Fernandez over 1 year ago

For the record: LTS of Wheezy ended in May 2018 according to https://www.debian.org/releases/wheezy/.

#2

Updated by Christian Eßl over 1 year ago

And -auto-orient has been supported in graphicsmagick for over 7 years now. So it's debatable, if there are even still LTS supported OSes out there, that have a graphicsmagick version older than that.

#3

Updated by Georg Ringer about 1 year ago

  • Status changed from New to Closed

I am closing this issue as this issue won't be fixed and only occurs with outdated OS

Also available in: Atom PDF