Bug #91385

Story #91384: Backend login and referrer problems after recent TYPO3 9.5.17 and 10.4.2 security fixes

JavaScript error for extensions overriding login form

Added by Oliver Hader about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Authentication
Target version:
Start date:
2020-05-13
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

References

Result

Uncaught TypeError: Cannot read property 'dataset' of null
    at Object.checkDocumentReferrerSupport (Login.js?bust=faffa50f23d88203ecae384d214e3cff8a87cd1a:13)
    at new <anonymous> (Login.js?bust=faffa50f23d88203ecae384d214e3cff8a87cd1a:13)
    at Object.<anonymous> (Login.js?bust=faffa50f23d88203ecae384d214e3cff8a87cd1a:13)
    at Object.execCb (require.js:5)
    at i.check (require.js:5)
    at i.<anonymous> (require.js:5)
    at require.js:5
    at require.js:5
    at each (require.js:5)
    at i.emit (require.js:5)

Related issues

Duplicated by TYPO3 Core - Bug #91415: After Update from 9.5.14 to 9.5.17 - backend and installer login are not working Closed 2020-05-15

Associated revisions

Revision 67944aa4 (diff)
Added by Oliver Hader about 2 months ago

[BUGFIX] Check for existence of `t3js-login-url` id in Login dialog

HTML element with identifier `t3js-login-url` is used to check whether
referrer handling is activated and suported. In case the `Login.html`
template has been overridden, mentioned element might not be given at
all - which leads to a corresponding JavaScript error.

Resolves: #91385
Releases: master, 9.5
Change-Id: Ie986a94209809c32cdfb217aa00b42f4369c525a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64484
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Andreas Fernandez <>

Revision f06fa298 (diff)
Added by Oliver Hader about 2 months ago

[BUGFIX] Check for existence of `t3js-login-url` id in Login dialog

HTML element with identifier `t3js-login-url` is used to check whether
referrer handling is activated and suported. In case the `Login.html`
template has been overridden, mentioned element might not be given at
all - which leads to a corresponding JavaScript error.

Resolves: #91385
Releases: master, 9.5
Change-Id: Ie986a94209809c32cdfb217aa00b42f4369c525a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64485
Tested-by: TYPO3com <>
Tested-by: André Schließer <>
Tested-by: Andreas Fernandez <>
Reviewed-by: André Schließer <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Oliver Hader about 2 months ago

  • Is Regression set to Yes

#2 Updated by Oliver Hader about 2 months ago

  • Description updated (diff)

#3 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64484

#4 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64485

#5 Updated by Oliver Hader about 2 months ago

  • Target version set to 9.5.18 & 10.4.3

#6 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64485

#7 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64484

#8 Updated by Stig Nørgaard Færch about 2 months ago

Gerrit Code Review wrote:

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64484

It works fine for me, though I had to remove the diff part for
typo3/sysext/backend/Resources/Private/TypeScript/Login.ts
as this file does not exist on my installation.
Guess it only exists in a dev installation somehow? I'm curious...

#9 Updated by Oliver Hader about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Oliver Hader about 2 months ago

  • Duplicated by Bug #91415: After Update from 9.5.14 to 9.5.17 - backend and installer login are not working added

#11 Updated by Oliver Hader about 2 months ago

  • Category set to Authentication

#12 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF